SSHSessionProcessProtocol does not implement getHost/getPeer.

[jrydberg]

session.SSHSessionProcessProtocol does not implement getHost/getPeer methods of the transport interface.

[z3p]

Tagging soc2007

[exarkun]

These should return some sort of IAddress. An easy solution would be to just return the host/peer that the corresponding getHost or getPeer method on the wrapped session.conn.transport would return (of course it's somewhat gross to reach that far out of the SSHSessionProcessProtocol... but it's not exactly surprising in Conch).

[salgado]

I'm probably missing something, but it confuses me that SSHSessionProcessProtocol should implement methods of the transport interface when it doesn't seem to provide ITransport?

[salgado]

I discussed this with exarkun and it seems that SSHSessionProcessProtocol should be marked as implementing ITransport, so I may do that as well.

[salgado]

This is my first attempt at adding getHost/getPeer to SSHSessionProcessProtocol. I couldn't resist adding/removing some blank lines to make the surroundings of what I changed follow the current policy (2 lines between methods and 3 between top-level classes is what I was told).

[exarkun]

(In [31141]) Branching to 'session-transport-addresses-2453'

[exarkun]

(In [31142]) Apply patch from the ticket

refs #2453

[exarkun]

Great, thanks! The tests and implementation look good, except for assertEqual which I'll change to assertEquals before merging.  Build results also look good (at least, as good as I expect them to look at the moment). So I'll go ahead and apply this. Thanks again!

[exarkun]

(In [31146]) Merge session-transport-addresses-2453

Author: salgado Reviewer: exarkun Fixes: #2453

Add getHost and getPeer methods to SSHSessionProcessProtocol, used as the transport for subsystem protocols.