Ticket #2374 defect closed fixed

Opened 6 years ago

Last modified 5 years ago

testOpenSSLBuffering fails intermittently on a dapper machine (running in vmware) because it uses reactor.iterate

Reported by: radix Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: Branch: branches/test-ssl-iterate-2374
Author: therve Launchpad Bug:

Description

Test Pass 128
Running 1 tests.
twisted.test.test_ssl
  BufferingTestCase
    testOpenSSLBuffering ...                                             [FAIL]

===============================================================================
[FAIL]: twisted.test.test_ssl.BufferingTestCase.testOpenSSLBuffering

Traceback (most recent call last):
  File "/home/radix/usr/lib/python2.4/site-packages/twisted/test/test_ssl.py", line 369, in testOpenSSLBuffering
    self.assertEquals(client.buffer, ["+OK <some crap>\r\n"])
twisted.trial.unittest.FailTest: [] != ['+OK <some crap>\r\n']
-------------------------------------------------------------------------------

The test uses reactor.iterate in a super lame way, and if I change the following line:

while i < 5000 and not client.buffer:

To have a larger upper bound (say, 50,000) it very reliably passes. It shouldn't be doing iterate explicitly.

Change History

1

Changed 5 years ago by therve

  • branch set to branches/test-ssl-iterate-2374
  • author set to therve

(In [23461]) Branching to 'test-ssl-iterate-2374'

2

Changed 5 years ago by therve

This should close #2918 too.

3

Changed 5 years ago by therve

  • owner changed from jknight to therve

4

Changed 5 years ago by therve

  • owner therve deleted
  • keywords review added; intermittent removed

5

Changed 5 years ago by exarkun

  • keywords review removed
  • owner set to therve

_runTest could use a docstring. Other than that, looks good. Merge when ready.

6

Changed 5 years ago by therve

  • status changed from new to closed
  • resolution set to fixed

(In [23717]) Merge test-ssl-iterate-2374

Author: therve Reviewer: exarkun Fixes #2374 Fixes #2918

Remove reactor.iterate calls from test_ssl.

7

Changed 2 years ago by <automation>

  • owner therve deleted
Note: See TracTickets for help on using tickets.