FilePath should allow access to all possible paths on Windows
|Reported by:||jknight||Owned by:|
|Cc:||teratorn, Zancas, davidsarah, zooko@…, hbock||Branch:|
Description (last modified by exarkun)
FilePath incorrectly prohibits access to certain files, due to the crummy APIs it's using.
For example, you can actually have a file called "CON" on windows, and it is accessible by quoting the path in various ways (or by accessing it via native Windows APIs), but FilePath would currently consider that path a security violation, regardless of whether it actually exists.
Additionally, Windows paths may natively be unicode. FilePath doesn't really pay attention to unicode vs str, so it may be broken with respect to non-ASCII(?) paths. Even if it does work, it needs unit tests to demonstrate this and prevent regressions.
Change History (23)
comment:4 Changed 7 years ago by glyph
- Description modified (diff)
- Summary changed from Make filepath work on windows to FilePath should allow access to all possible paths on Windows
comment:15 in reply to: ↑ 14 Changed 4 years ago by glyph
- Branch set to /branches/win-filepath-2366-2
comment:16 Changed 2 years ago by hbock
- Branch /branches/win-filepath-2366-2 deleted
- Cc hbock added
- Keywords review added