Ticket #2338 enhancement closed fixed

Opened 6 years ago

Last modified 5 years ago

trial should handle concurrent usage in the same directory gracefully

Reported by: exarkun Owned by:
Priority: high Milestone:
Component: trial Keywords:
Cc: Branch: branches/concurrent-trial_temp-2338
Author: exarkun Launchpad Bug:

Description

Currently a second trial process started in the same directory as a first will destroy the first's _trial_temp directory causing most or all of the remaining tests run by the first process to fail. trial should handle this case without breaking things in this manner.

Change History

1

Changed 6 years ago by jml

  • priority changed from normal to low

2

Changed 5 years ago by exarkun

  • status changed from new to assigned
  • owner changed from jml to exarkun
  • priority changed from low to high

3

Changed 5 years ago by exarkun

  • branch set to branches/concurrent-trial_temp-2338
  • author set to exarkun

(In [24287]) Branching to 'concurrent-trial_temp-2338'

4

Changed 5 years ago by exarkun

  • status changed from assigned to new
  • keywords review added

5

Changed 5 years ago by exarkun

  • owner exarkun deleted

6

Changed 5 years ago by therve

  • keywords review removed
  • owner set to exarkun

Looks good. One minor comment:

+ testdir = base + '-' + str(counter)

"%s-%s" would make that more readable.

Thanks!

7

Changed 5 years ago by exarkun

(In [24320]) Use interpolation instead of concatenation to create the temp dir name

refs #2338

8

Changed 5 years ago by exarkun

(In [24321]) avoid the repeated stringification

refs #2338

9

Changed 5 years ago by exarkun

  • status changed from new to closed
  • resolution set to fixed

(In [24325]) Merge concurrent-trial_temp-2338

Author: exarkun Reviewer: therve Fixes: #2338

Add a lock to the _trial_temp directory so that different test processes don't try to use the same directory at the same time. If no temporary directory is specified, a different default will silently be selected if the preferred default is found to be in use. If a temporary directory is specified and found to be in use, an error will be reported.

10

Changed 2 years ago by <automation>

  • owner exarkun deleted
Note: See TracTickets for help on using tickets.