Ticket #2236 task closed wontfix

Opened 7 years ago

Last modified 4 years ago

Make test_toc adhere to coding standard

Reported by: jml Owned by:
Priority: low Milestone:
Component: words Keywords:
Cc: Branch:
Author: Launchpad Bug:

Description (last modified by glyph) (diff)

  • fix vertical whitespace
  • add docstrings to tests
  • remove dead code (testCases variable, testSuite function)

Change History

1

Changed 7 years ago by jml

  • summary changed from Make test_toc less skanky to Clean up test_toc

In particular: * test_toc has no regard for vertical whitespace * test should have docstrings explaining what the tests do * the tests in test_toc are extremely long and unclear. They should be split into actual unit tests. * in trunk, it defines an unused testCases variable

2

Changed 7 years ago by glyph

  • description modified (diff)
  • summary changed from Clean up test_toc to Make test_toc adhere to coding standard

Let's restrict the scope of this ticket so it's achievable.

Also, why's it assigned to JP? This is z3p's code.

3

Changed 7 years ago by glyph

I just added #2238 to reflect the parts of this ticket which are beyond the scope of a simple cleanup.

4

Changed 6 years ago by exarkun

  • owner changed from exarkun to z3p

5

Changed 4 years ago by thijs

  • status changed from new to closed
  • resolution set to wontfix

Closing because TOC is going to be removed (#4363).

6

Changed 3 years ago by <automation>

  • owner z3p deleted
Note: See TracTickets for help on using tickets.