Opened 8 years ago

Closed 8 years ago

#2158 enhancement closed fixed (fixed)

SMTP server incorrectly handles SMTPBadSender from validateFrom

Reported by: exarkun Owned by:
Priority: highest Milestone:
Component: mail Keywords:
Cc: Branch:
Author: Launchpad Bug:

Description

It first tells the client that the address was rejected. It next tells the client that the address was accepted.

Change History (8)

comment:1 Changed 8 years ago by exarkun

  • Keywords review added
  • Priority changed from normal to highest

Fixed in validatefrom-2158

comment:2 Changed 8 years ago by exarkun

  • Owner exarkun deleted

comment:3 Changed 8 years ago by therve

  • Keywords review removed
  • Owner set to exarkun

Looks good. Just one typo in _ebAuthenticated docstring ('tra nslating').

comment:4 Changed 8 years ago by exarkun

Fixed that docstring. Harsh light of day motivates me to make a couple further exception handling cleanups in this branch, though.

comment:5 Changed 8 years ago by exarkun

  • Keywords review added
  • Owner exarkun deleted

Okay, cleaned up a bit and added some more tests. This also fixes response decode error handling now.

comment:6 Changed 8 years ago by washort

  • Keywords review removed
  • Owner set to exarkun

Looks good, tests pass, and it fixes the problem. Code looks simpler, which is nice.

comment:7 Changed 8 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [18417]) Merge validatefrom-2158

Author: exarkun
Reviewer: therve, washort
Fixes #2158

Add tests for handling of various IMessageDelivery implementation behaviors,
including exceptions from validateFrom. Also add tests for failures from
portal.login and base64 decoding of challenge response strings. Fix bugs
revealed by all of these tests.

comment:8 Changed 3 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.