Opened 11 years ago

Closed 11 years ago

#2158 enhancement closed fixed (fixed)

SMTP server incorrectly handles SMTPBadSender from validateFrom

Reported by: Jean-Paul Calderone Owned by:
Priority: highest Milestone:
Component: mail Keywords:
Cc: Branch:
Author:

Description

It first tells the client that the address was rejected. It next tells the client that the address was accepted.

Change History (8)

comment:1 Changed 11 years ago by Jean-Paul Calderone

Keywords: review added
Priority: normalhighest

Fixed in validatefrom-2158

comment:2 Changed 11 years ago by Jean-Paul Calderone

Owner: Jean-Paul Calderone deleted

comment:3 Changed 11 years ago by therve

Keywords: review removed
Owner: set to Jean-Paul Calderone

Looks good. Just one typo in _ebAuthenticated docstring ('tra nslating').

comment:4 Changed 11 years ago by Jean-Paul Calderone

Fixed that docstring. Harsh light of day motivates me to make a couple further exception handling cleanups in this branch, though.

comment:5 Changed 11 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

Okay, cleaned up a bit and added some more tests. This also fixes response decode error handling now.

comment:6 Changed 11 years ago by washort

Keywords: review removed
Owner: set to Jean-Paul Calderone

Looks good, tests pass, and it fixes the problem. Code looks simpler, which is nice.

comment:7 Changed 11 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [18417]) Merge validatefrom-2158

Author: exarkun Reviewer: therve, washort Fixes #2158

Add tests for handling of various IMessageDelivery implementation behaviors, including exceptions from validateFrom. Also add tests for failures from portal.login and base64 decoding of challenge response strings. Fix bugs revealed by all of these tests.

comment:8 Changed 6 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.