Opened 11 years ago

Closed 10 years ago

#2087 enhancement closed duplicate (duplicate)

buffer size doubling for iocpreactor

Reported by: ghazel Owned by:
Priority: normal Milestone:
Component: core Keywords: iocp
Cc: Branch:
Author:

Description

IOCP currently eats 65k per connection for a read buffer. This large memory overhead can be reduced without much cpu overhead by starting small and doubling every time the readbuffer is 100% utilized.

Attached is a patch which accomplishes this

Attachments (1)

buffer.diff (2.7 KB) - added by ghazel 11 years ago.
buffer doubling patch for abstract.py (tab removal)

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by Jean-Paul Calderone

There are no tests in this patch. It should have some added before it is applied. As the code is currently factored, it looks like it will be pretty tough to write any unit tests for the behavior change, so the code should probably be refactored too.

comment:2 Changed 11 years ago by ghazel

You can run all the standard reactor tests to make sure iocp still works.

Writing a unit test for this seems pointless otherwise. There's no unit test for the old behaviour either.

Changed 11 years ago by ghazel

Attachment: buffer.diff added

buffer doubling patch for abstract.py (tab removal)

comment:3 Changed 10 years ago by PenguinOfDoom

Resolution: duplicate
Status: newclosed

Implemented in #1760

comment:4 Changed 7 years ago by <automation>

Owner: PenguinOfDoom deleted
Note: See TracTickets for help on using tickets.