Opened 8 years ago

Closed 8 years ago

#2065 defect closed fixed (fixed)

windows buildbot errors, already imported failures

Reported by: scmikes Owned by:
Priority: highest Milestone: Core-2.5
Component: core Keywords: error buildbot win32
Cc: glyph, radix, scmikes, exarkun Branch:
Author: Launchpad Bug:

Description (last modified by exarkun)

ERROR]: twisted.test.test_modules.BasicTests.test_loadPackagesAndModules

Traceback (most recent call last):
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 73, in test_loadPackagesAndModules
    self.failUnlessIdentical(
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 27, in findByIteration
    for modinfo in where.walkModules(importPackages=importPackages):
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 602, in walkModules
    for package in self.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 596, in iterModules
    for module in entry.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 118, in iterModules
    for potentialTopLevel in placeToLook.children():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 59, in children
    return map(self.child, self.listdir())
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 291, in listdir
    return listdir(self.path)
exceptions.WindowsError: [Errno 267] The directory name is invalid: 'c:\\python24\\lib\\site-packages\\sasync-0.1-py2.4.egg/*.*'
===============================================================================
[ERROR]: twisted.test.test_modules.BasicTests.test_onlyTopModules

Traceback (most recent call last):
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 55, in test_onlyTopModules
    for module in modules.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 596, in iterModules
    for module in entry.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 118, in iterModules
    for potentialTopLevel in placeToLook.children():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 59, in children
    return map(self.child, self.listdir())
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 291, in listdir
    return listdir(self.path)
exceptions.WindowsError: [Errno 267] The directory name is invalid: 'c:\\python24\\lib\\site-packages\\sasync-0.1-py2.4.egg/*.*'
===============================================================================
[ERROR]: twisted.test.test_modules.PathModificationTest.test_listingModules

Traceback (most recent call last):
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 163, in test_listingModules
    self._listModules()
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 152, in _listModules
    pkginfo = modules.getModule(self.packageName)
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 625, in getModule
    return theSystemPath[moduleName]
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 584, in __getitem__
    for module in self.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 596, in iterModules
    for module in entry.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 118, in iterModules
    for potentialTopLevel in placeToLook.children():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 59, in children
    return map(self.child, self.listdir())
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 291, in listdir
    return listdir(self.path)
exceptions.WindowsError: [Errno 267] The directory name is invalid: 'c:\\python24\\lib\\site-packages\\sasync-0.1-py2.4.egg/*.*'
===============================================================================
[ERROR]: twisted.test.test_modules.PathModificationTest.test_underUnderPathAlreadyImported

Traceback (most recent call last):
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 138, in test_underUnderPathAlreadyImported
    self._underUnderPathTest()
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 127, in _underUnderPathTest
    modinfo = modules.getModule(self.packageName)
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 625, in getModule
    return theSystemPath[moduleName]
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 584, in __getitem__
    for module in self.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 596, in iterModules
    for module in entry.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 118, in iterModules
    for potentialTopLevel in placeToLook.children():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 59, in children
    return map(self.child, self.listdir())
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 291, in listdir
    return listdir(self.path)
exceptions.WindowsError: [Errno 267] The directory name is invalid: 'c:\\python24\\lib\\site-packages\\sasync-0.1-py2.4.egg/*.*'
===============================================================================
[ERROR]: twisted.test.test_modules.ZipPathModificationTest.test_listingModules

Traceback (most recent call last):
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 163, in test_listingModules
    self._listModules()
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 152, in _listModules
    pkginfo = modules.getModule(self.packageName)
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 625, in getModule
    return theSystemPath[moduleName]
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 584, in __getitem__
    for module in self.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 596, in iterModules
    for module in entry.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 118, in iterModules
    for potentialTopLevel in placeToLook.children():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 59, in children
    return map(self.child, self.listdir())
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 291, in listdir
    return listdir(self.path)
exceptions.WindowsError: [Errno 267] The directory name is invalid: 'c:\\python24\\lib\\site-packages\\sasync-0.1-py2.4.egg/*.*'
===============================================================================
[ERROR]: twisted.test.test_modules.ZipPathModificationTest.test_underUnderPathAlreadyImported

Traceback (most recent call last):
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 138, in test_underUnderPathAlreadyImported
    self._underUnderPathTest()
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_modules.py", line 127, in _underUnderPathTest
    modinfo = modules.getModule(self.packageName)
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 625, in getModule
    return theSystemPath[moduleName]
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 584, in __getitem__
    for module in self.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 596, in iterModules
    for module in entry.iterModules():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\modules.py", line 118, in iterModules
    for potentialTopLevel in placeToLook.children():
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 59, in children
    return map(self.child, self.listdir())
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\python\filepath.py", line 291, in listdir
    return listdir(self.path)
exceptions.WindowsError: [Errno 267] The directory name is invalid: 'c:\\python24\\lib\\site-packages\\sasync-0.1-py2.4.egg/*.*'
===============================================================================
[ERROR]: twisted.test.test_udp.MulticastTestCase.testMulticast

Traceback (most recent call last):
  File "e:\twistedbuildbot\W32-full2.4-scmikes-select\Twisted\twisted\test\test_udp.py", line 679, in testMulticast
    self.assertEquals(self.server.packets[0][0], "hello world")
exceptions.IndexError: list index out of range
-------------------------------------------------------------------------------

Change History (12)

comment:1 Changed 8 years ago by exarkun

  • Description modified (diff)

comment:2 Changed 8 years ago by TimothyFitz

  • Keywords win32 added; windows removed

comment:3 Changed 8 years ago by radix

Can someone please explain what is going on here.

comment:4 Changed 8 years ago by radix

  • Cc glyph radix scmikes added

comment:5 Changed 8 years ago by radix

  • Milestone set to Twisted-2.5

comment:6 Changed 8 years ago by glyph

  • Owner changed from glyph to teratorn

I am not the windows maintainer.

comment:7 Changed 8 years ago by scmikes

This defect is triggered by the async egg. This seems to be a problem with reading from the egg.

comment:8 Changed 8 years ago by glyph

  • Owner changed from teratorn to TimothyFitz

comment:9 Changed 8 years ago by exarkun

  • Cc exarkun added
  • Keywords review added
  • Owner TimothyFitz deleted

In modules-listdir-2065, t.p.modules now has tests for the case where sys.path contains a path which does not exist as well as a path which refers to a regular file rather than a directory, and performs error handling around the FilePath.children call to notice and ignore these cases.

Please review.

comment:10 Changed 8 years ago by jml

  • Keywords review removed
  • Owner set to exarkun

Looks good. Glad that the windows stuff got moved from plugin.py to win32.py

Only complaint is that the phrase "does not prevent walkModules from producing other results" (iin docstrings for tests) is quite vague and the earlier negative makes it difficult to parse. Perhaps "Check that sys.modules ignores path names in sys.path that refer to _" instead.

Please fix and then merge.

comment:11 Changed 8 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [18695]) Merge modules-listdir-2065-2

Author: exarkun
Reviewer: jml
Fixes #2065

Handle non-existent and non-directory entries in a plugin package's
path attribute. Tests for same.

comment:12 Changed 4 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.