Ticket #2053 defect new

Opened 7 years ago

Last modified 15 months ago

twisted.test.test_import is redundant

Reported by: exarkun Owned by:
Priority: normal Milestone:
Component: core Keywords:
Cc: therve, thijs Branch:
Author: Launchpad Bug:

Description

We used to have pretty crudtastic test coverage. Having some tests that at least imported some modules that might not have been imported anyplace else was useful.

Is this still the case? If so, we seriously need to write some tests. If not, we should get rid of test_import, because it serves no purpose.

Change History

1

  Changed 6 years ago by therve

  • cc therve added

I had a quick look at this, and unfortunately there is at least one module inside test_import without unittests: twisted.python.otp. Maybe we can still remove these tests and create a ticket for adding tests to otp?

2

  Changed 2 years ago by <automation>

  • owner exarkun deleted

3

  Changed 19 months ago by thijs

  • cc thijs added

What's the decision on this ticket?

4

follow-up: ↓ 5   Changed 19 months ago by exarkun

twisted.python.otp is deprecated (since 9.0, it seems, though it misreports as 8.3). So we can get rid of that module and then presumably we can get rid of test_import, supposing that we have coverage for everything else it is importing.

5

in reply to: ↑ 4   Changed 15 months ago by thijs

Replying to exarkun:

twisted.python.otp is deprecated (since 9.0, it seems, though it misreports as 8.3). So we can get rid of that module

I've opened #5493 for this.

Note: See TracTickets for help on using tickets.