Opened 11 years ago

Closed 10 years ago

#2021 enhancement closed duplicate (duplicate)

iocpreactor.tcp.ClientSocket should implement ISystemHandle

Reported by: ghazel Owned by: ghazel
Priority: highest Milestone:
Component: core Keywords: windows, iocpreactor
Cc: Branch:
Author:

Description

Dead simple, branching to implement it now

Change History (4)

comment:1 Changed 11 years ago by ghazel

Keywords: review added

iocp_syshandle-2021

comment:2 Changed 11 years ago by Jean-Paul Calderone

Priority: normalhighest

comment:3 Changed 11 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: changed from Glyph to ghazel

implements() can only be used once in a class definition, so the udp.py changes are broken.

There should be some tests for this code. Set up a connection and call the method to make sure it doesn't raise an exception, perhaps? Not a very good test, but better than nothing.

comment:4 Changed 10 years ago by PenguinOfDoom

Keywords: windows iocpreactor added
Resolution: duplicate
Status: newclosed

Implemented in #1760

Note: See TracTickets for help on using tickets.