Remove repr() and getDelayedCalls() usage from twisted.web.test.test_web.SessionTest.test_delayedCallCleanup
|Reported by:||exarkun||Owned by:|
Comparing repr()s of things is pretty terrible. We shouldn't do it. Structured objects FTW.
getDelayedCalls should never have been added to IReactorTime. We should avoid using it wherever possible, remove all existing usages of it from the codebase, and then remove it. But that's a separate ticket. For this ticket, just remove it from test_delayedCallCleanup.
Session creation should be parameterized such that the clock used for scheduling is accessible to the test suite and a fake one which does not involve the reactor or real wallclock time can be specified for the test.
Change History (9)
Changed 8 years ago by therve
comment:3 Changed 8 years ago by therve
- Cc therve added
- Keywords review added
- Owner acapnotic deleted
- Priority changed from normal to highest