Ticket #1950 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

PyUnitTestCase.id is redundant and should be removed

Reported by: glyph Owned by: jml
Priority: normal Milestone:
Component: trial Keywords:
Cc: Branch:
Author: Launchpad Bug:

Description

The reason it has not been is that it causes doctest tests to start failing, but perhaps doctest should have individual support.

Change History

Changed 4 years ago by jml

  • status changed from new to assigned

Changed 3 years ago by jml

The branch for #2898 should make this easier to change.

Changed 3 years ago by jml

  • branch set to branches/remove-id-1950

Changed 3 years ago by jml

  • branch changed from branches/remove-id-1950 to branches/remove-id-1950-2

Changed 3 years ago by jml

(In [21788]) Hey look! I can delete this and the tests still pass.

Turns out that our re-implementation of id() for pyunit TestCase is totally unnecessary.

Refs #1950.

Changed 3 years ago by jml

  • branch branches/remove-id-1950-2 deleted

Now being fixed in the branch for #2898.

Changed 3 years ago by jml

  • status changed from assigned to closed
  • resolution set to fixed

(In [21827]) Define ITestCase to be the interface that test frameworks expect of a test.

  • Author: jml
  • Reviewers: therve, exarkun
  • Fixes #2898

ITestCase is re-purposed to define what you can expect from a test object. We use this interface to adapt pyunit tests to things usable in Trial.

In the process we also clarify what's needed for compatibility with doctest and pyunit.

This branch also fixes #1950.

Refs #2739.

Note: See TracTickets for help on using tickets.