Ticket #1919 defect closed fixed

Opened 7 years ago

Last modified 7 years ago

Watering the twisted.web2 docstring desert

Reported by: edsuom Owned by:
Priority: normal Milestone:
Component: web2 Keywords:
Cc: Branch:
Author: Launchpad Bug:

Description

twisted.web2.client.http is devoid of docstrings. There are probably other equally important twisted.web2 modules that need docstring TLC, too.

Change History

1

Changed 7 years ago by dreid

  • keywords review added

I've written docstrings for web2 client, vhost, some things in http and some things in http_headers. The focus is on user APIs.

More doc strings could be written but I'd like to go ahead and merge and close this bug so it doesn't get stagnant.

branched to source:branches/web2-docstring-1919

2

Changed 7 years ago by dreid

  • owner dreid deleted

3

Changed 7 years ago by moonfallen

  • keywords review removed
  • owner set to dreid

These all read fine. Fixed a few typos, that's about it.

4

Changed 7 years ago by moonfallen

Crap, should have actually run the tests. "no module named interfaces" ... I will fix, don't check in yet.

5

Changed 7 years ago by moonfallen

OK, tests pass in r17451.

6

Changed 7 years ago by dreid

  • status changed from new to closed
  • resolution set to fixed

(In [17544]) Docstrings for various userfacing methods and classes.

This also contains a few extra lines for readability sake.

Reviewer: MFen Author: dreid Fixes #1919

7

Changed 2 years ago by <automation>

  • owner dreid deleted
Note: See TracTickets for help on using tickets.