Opened 8 years ago

Closed 7 years ago

#1917 defect closed fixed (fixed)

Typo in twisted.mail.mail.DomainWithDefaultDict

Reported by: therve Owned by:
Priority: highest Milestone:
Component: mail Keywords:
Cc: therve, exarkun Branch:
Author: Launchpad Bug:

Description

DomainWithDefaultDict is misspelled DomainWithDefaultsDict in the methods copy, str and repr.

Attachments (2)

mail_1917.diff (866 bytes) - added by therve 8 years ago.
test_mail_1917.diff (573 bytes) - added by therve 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by therve

Changed 8 years ago by therve

comment:1 Changed 8 years ago by therve

Attached a path correcting the behaviour and one test for the copy method.

comment:2 Changed 8 years ago by exarkun

  • Cc exarkun added

I've been considering just deleting that class. Do you know of any code which uses it directly?

comment:3 Changed 8 years ago by therve

No, I was just playing with MailService when I saw this problem. I guess there should be a simpler way to define the BounceDomain, so we can remove this.

comment:4 Changed 7 years ago by exarkun

  • Keywords review added
  • Owner exarkun deleted

alright. well, it's not even deprecated, so I can't delete it yet. I applied your patch and made some further changes in domain-with-defaults-1917

comment:5 Changed 7 years ago by therve

  • Keywords review removed
  • Owner set to exarkun
  • Priority changed from normal to highest
  • _stringificationTest may benefit from a docstring
  • update copyright for mail.py

Then please merge.

comment:6 Changed 7 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [20983]) Merge domain-with-defaults-1917

Author: exarkun, therve
Reviewer: therve
Fixes #1917

Fix several spelling errors in the domain support class in twisted.mail.mail
and add test coverage for the fixed methods.

comment:7 Changed 4 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.