Ticket #1916 defect closed wontfix

Opened 7 years ago

Last modified 3 years ago

Pyflakes errors in twisted.web2 need fixing

Reported by: jerub Owned by:
Priority: low Milestone:
Component: web2 Keywords:
Cc: thijs Branch:
Author: Launchpad Bug:

Description 

trunk/twisted/web2 $ pyflakes *.py | grep undef
error.py:9: 'from twisted.web2.responsecode import *' used; unable to detect undefined names
requtil.py:56: undefined name 'self'
requtil.py:64: undefined name 'site'
stream.py:201: undefined name 'SendfileBuffer'
stream.py:1009: undefined name 'LineTooLongException'
stream.py:1012: undefined name 'LineTooLongException'
tap.py:146: undefined name 'isintance'

Attachments

pyflakes-web2-1916.patch Download (503 bytes) - added by thijs 5 years ago.
patch against r24264

Change History

1

  Changed 7 years ago by jerub

  • type changed from enhancement to defect

2

  Changed 6 years ago by dreid

  • milestone set to Web2-0.3

3

  Changed 5 years ago by collab

  • cc collab added
  • status changed from new to assigned
  • owner changed from jknight to collab

4

  Changed 5 years ago by thijs

  • cc thijs added; collab removed
  • owner changed from collab to thijs
  • status changed from assigned to new

5

follow-up: ↓ 6   Changed 5 years ago by thijs

  • status changed from new to assigned

Status of web2 is currently: 

twisted/web2$ pyflakes *.py | grep undef
error.py:9: 'from twisted.web2.responsecode import *' used; unable to detect undefined names
stream.py:201: undefined name 'SendfileBuffer'
tap.py:141: undefined name 'isintance'

Changed 5 years ago by thijs

patch against r24264

6

in reply to: ↑ 5   Changed 5 years ago by thijs

  • keywords review added
  • owner thijs deleted
  • status changed from assigned to new

Replying to thijs:

error.py:9: 'from twisted.web2.responsecode import *' used; unable to detect undefined names

Don't think we can fix this easily without the risk of breaking stuff, unless someone has a good suggestion to figure out which vars are imported.

stream.py:201: undefined name 'SendfileBuffer'

What to do about this one? It's marked with comments like: 

# XXX: Yay using non-existent sendfile support!
# FIXME: if we return a SendfileBuffer, and then sendfile
#        fails, then what? Or, what if file is too short?

tap.py:141: undefined name 'isintance'

See attached patch Download that fixes this line.

7

  Changed 5 years ago by therve

  • priority changed from normal to low
  • owner set to thijs

The change should be accompanied by a test. Don't spend too much time on this tough, as web2 is being phased out.

8

  Changed 5 years ago by therve

  • keywords review removed

9

  Changed 5 years ago by thijs

  • owner thijs deleted

10

  Changed 4 years ago by exarkun

  • milestone Twisted-8.2+1 deleted

I can't see any reason this needs to be targeted at 9.0 (8.2+1).

11

  Changed 3 years ago by thijs

  • status changed from new to closed
  • resolution set to wontfix

I'm closing it because it's being phased out and should be fixed in a other ticket that makes changes in the same module/class.

12

  Changed 2 years ago by <automation>

Note: See TracTickets for help on using tickets.