Opened 10 years ago

Closed 10 years ago

#1752 defect closed wontfix (wontfix)

t.w2's header tests that use runRoundtripTest and requiredGeneratedElements are invalid.

Reported by: dreid Owned by: dreid
Priority: normal Milestone:
Component: web2 Keywords:
Cc: Branch:


twisted.web2.test.test_http_headers.HeaderParsingTestBase.runRoundtripTest's requiredGeneratedElements functionality is invalid for any generator that produces a condensed single line comma seperated list of headers.

Change History (4)

comment:1 Changed 10 years ago by dreid

  • Priority changed from normal to high
  • Status changed from new to assigned

comment:2 Changed 10 years ago by dreid

Minddump follows.

This issue applies to multiple generated headers that could have elements repeated between several headers. such as WWW-Authenticate with multiple schemes for a single realm. I do not believe any other headers display similar behavior, and therefor no other header testcases are invalid. Since WWW-Authenticate's tests do not use runRoundtripTest instead a custom variation of runRoundtripTest it is not invalid in current trunk. We can't make WWW-Authenticate generate a single header because no browsers can parse it, and it wouldn't fix the problem anyway. While not entirely invalid all the unittests that use the 3rd table element (required generated elements) are wrong because they are not testing the header in it's entirety. This is possibly unrectifiable without using an ordered dictionary as many headers using that behavior are generated from dictionaries. We could require that a header with an odict be passed in for the generator and compare that string in it's entirety. Since it is probably wrong to rely on the output of the parser for anything other than making sure we can generate headers we parse.

comment:3 Changed 10 years ago by dreid

  • Priority changed from high to normal

I need to reevaluate the applicability of this issue to the majority of test cases.

comment:4 Changed 10 years ago by dreid

  • Resolution set to wontfix
  • Status changed from assigned to closed

I haven't found this to affect any headers other than www-authenticate.

Note: See TracTickets for help on using tickets.