Opened 11 years ago

Closed 10 years ago

#1730 defect closed fixed (fixed)

twisted.test.test_tcp.HalfClose3TestCase.testReadNotificationRaises fails intermittently

Reported by: radix Owned by:
Priority: highest Milestone:
Component: core Keywords:
Cc: therve Branch:
Author:

Description

At least on my x86/OS X machine.

  File "/Users/radix/tmp/lib/python2.4/site-packages/twisted/test/test_tcp.py", line 1124, in testReadNotificationRaises
    self.f.protocol.readConnectionLost = self.aBug
exceptions.AttributeError: 'NoneType' object has no attribute 'readConnectionLost'

Change History (8)

comment:1 Changed 10 years ago by Jean-Paul Calderone

#2256 was a duplicate of this.

comment:2 Changed 10 years ago by Jean-Paul Calderone

#2450 was a duplicate of this.

comment:3 Changed 10 years ago by Jean-Paul Calderone

Priority: normalhigh

This fails on Windows sometimes, too.

*bump*

comment:4 Changed 10 years ago by Jean-Paul Calderone

Owner: changed from jknight to Jean-Paul Calderone
Status: newassigned

comment:5 Changed 10 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted
Priority: highhighest
Status: assignednew

Fails in trunk on neutron (OS X host) within 100 runs pretty reliably. In read-notification-raises-1730, ran 4000+ times without failing. Please review!

comment:6 Changed 10 years ago by therve

Cc: therve added
Keywords: review removed
Owner: set to Jean-Paul Calderone

That looks OK, I couldn't reproduce the problem anymore under my vmware win32 machine.

Just one thing: aBug mentions readConnectionLost, it should probably mention writeConnectionLost too.

comment:7 Changed 10 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [21268]) Merge read-notification-raises-1730

Author: exarkun Reviewer: therve Fixes #1730

Rewrite two unit tests for a feature of half-close support so that they do not contain a race condition which sometimes results in the tests failing due to setup having been only partially completed.

comment:8 Changed 6 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.