twisted.test.test_tcp.HalfClose3TestCase.testReadNotificationRaises fails intermittently

[radix]

At least on my x86/OS X machine.

  File "/Users/radix/tmp/lib/python2.4/site-packages/twisted/test/test_tcp.py", line 1124, in testReadNotificationRaises
    self.f.protocol.readConnectionLost = self.aBug
exceptions.AttributeError: 'NoneType' object has no attribute 'readConnectionLost'

[exarkun]

#2256 was a duplicate of this.

[exarkun]

#2450 was a duplicate of this.

[exarkun]

This fails on Windows sometimes, too.

*bump*

[exarkun]

Fails in trunk on neutron (OS X host) within 100 runs pretty reliably. In read-notification-raises-1730, ran 4000+ times without failing. Please review!

[therve]

That looks OK, I couldn't reproduce the problem anymore under my vmware win32 machine.

Just one thing: aBug mentions readConnectionLost, it should probably mention writeConnectionLost too.

[exarkun]

(In [21268]) Merge read-notification-raises-1730

Author: exarkun Reviewer: therve Fixes #1730

Rewrite two unit tests for a feature of half-close support so that they do not contain a race condition which sometimes results in the tests failing due to setup having been only partially completed.