Opened 8 years ago

Closed 6 years ago

#1522 task closed fixed (fixed)

Remove woven from next release of twisted.web

Reported by: itamarst Owned by:
Priority: highest Milestone: Twisted-9.0
Component: web Keywords:
Cc: thijs Branch: branches/remove-woven-1522-2
(diff, github, buildbot, log)
Author: exarkun Launchpad Bug:

Description

Enough is enough.

Change History (16)

comment:1 Changed 8 years ago by itamarst

  • Component changed from core to web
  • Owner changed from glyph to foom

comment:2 follow-up: Changed 8 years ago by exarkun

docs shouldn't be removed until the code is

comment:3 Changed 8 years ago by jknight

  • Owner changed from foom to jknight

comment:4 in reply to: ↑ 2 Changed 6 years ago by collab

  • Cc collab added
  • Keywords documentation added
  • Type changed from enhancement to task

Replying to exarkun:

docs shouldn't be removed until the code is

Where can that code be found?

comment:5 follow-up: Changed 6 years ago by exarkun

twisted.web.woven :)

therve is working on a branch that removes the use of it from twisted.web.static. Not sure if there are any other uses in Twisted.

comment:6 in reply to: ↑ 5 Changed 6 years ago by collab

  • Owner changed from jknight to collab
  • Status changed from new to assigned

Replying to exarkun:

twisted.web.woven :)

therve is working on a branch that removes the use of it from twisted.web.static. Not sure if there are any other uses in Twisted.

Allright. Also saw pylint mentioning a cyclic import in the woven package.. good to hear its going ;) I could make a patch that scrapes out the documentation for that branch, which one is that?

comment:7 Changed 6 years ago by thijs

  • Cc thijs added; collab removed
  • Owner changed from collab to thijs
  • Status changed from assigned to new

comment:8 Changed 6 years ago by thijs

  • Owner changed from thijs to therve

assigning it to therve cause he's working on the woven cleanup.

comment:9 Changed 6 years ago by exarkun

  • Keywords documentation removed
  • Milestone set to Twisted-8.2+1
  • Priority changed from normal to highest
  • Summary changed from Remove woven documentation from next release of twisted.web to Remove woven from next release of twisted.web

Also to remove:

  • twisted/web/widgets.py
  • the woven support in twisted/web/tap.py
  • twisted/web/woven/ and associated tests

comment:10 Changed 6 years ago by exarkun

  • Owner changed from therve to exarkun
  • Status changed from new to assigned

comment:11 Changed 6 years ago by exarkun

  • Author set to exarkun
  • Branch set to branches/remove-woven-1522

(In [25874]) Branching to 'remove-woven-1522'

comment:12 Changed 6 years ago by exarkun

  • Keywords review added
  • Owner exarkun deleted
  • Status changed from assigned to new

Splat.

comment:13 Changed 6 years ago by therve

  • Keywords review removed
  • Owner set to exarkun

Awesome, please merge.

comment:14 Changed 6 years ago by exarkun

  • Branch changed from branches/remove-woven-1522 to branches/remove-woven-1522-2

(In [25918]) Branching to 'remove-woven-1522-2'

comment:15 Changed 6 years ago by exarkun

  • Resolution set to fixed
  • Status changed from new to closed

(In [25924]) Merge remove-woven-1522-2

Author: exarkun
Reviewer: therve
Fixes: #1522

Remove twisted.web.woven and all remaining code which used anything from
that package as well as the documentation for Woven.

comment:16 Changed 3 years ago by <automation>

  • Owner exarkun deleted
Note: See TracTickets for help on using tickets.