Opened 11 years ago

Closed 8 years ago

#1522 task closed fixed (fixed)

Remove woven from next release of twisted.web

Reported by: itamarst Owned by:
Priority: highest Milestone: Twisted-9.0
Component: web Keywords:
Cc: Thijs Triemstra Branch: branches/remove-woven-1522-2
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

Enough is enough.

Change History (16)

comment:1 Changed 11 years ago by itamarst

Component: coreweb
Owner: changed from Glyph to foom

comment:2 Changed 11 years ago by Jean-Paul Calderone

docs shouldn't be removed until the code is

comment:3 Changed 11 years ago by jknight

Owner: changed from foom to jknight

comment:4 in reply to:  2 Changed 9 years ago by collab

Cc: collab added
Keywords: documentation added
Type: enhancementtask

Replying to exarkun:

docs shouldn't be removed until the code is

Where can that code be found?

comment:5 Changed 9 years ago by Jean-Paul Calderone

twisted.web.woven :)

therve is working on a branch that removes the use of it from twisted.web.static. Not sure if there are any other uses in Twisted.

comment:6 in reply to:  5 Changed 9 years ago by collab

Owner: changed from jknight to collab
Status: newassigned

Replying to exarkun:

twisted.web.woven :)

therve is working on a branch that removes the use of it from twisted.web.static. Not sure if there are any other uses in Twisted.

Allright. Also saw pylint mentioning a cyclic import in the woven package.. good to hear its going ;) I could make a patch that scrapes out the documentation for that branch, which one is that?

comment:7 Changed 9 years ago by Thijs Triemstra

Cc: Thijs Triemstra added; collab removed
Owner: changed from collab to Thijs Triemstra
Status: assignednew

comment:8 Changed 8 years ago by Thijs Triemstra

Owner: changed from Thijs Triemstra to therve

assigning it to therve cause he's working on the woven cleanup.

comment:9 Changed 8 years ago by Jean-Paul Calderone

Keywords: documentation removed
Milestone: Twisted-8.2+1
Priority: normalhighest
Summary: Remove woven documentation from next release of twisted.webRemove woven from next release of twisted.web

Also to remove:

  • twisted/web/widgets.py
  • the woven support in twisted/web/tap.py
  • twisted/web/woven/ and associated tests

comment:10 Changed 8 years ago by Jean-Paul Calderone

Owner: changed from therve to Jean-Paul Calderone
Status: newassigned

comment:11 Changed 8 years ago by Jean-Paul Calderone

Author: exarkun
Branch: branches/remove-woven-1522

(In [25874]) Branching to 'remove-woven-1522'

comment:12 Changed 8 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted
Status: assignednew

Splat.

comment:13 Changed 8 years ago by therve

Keywords: review removed
Owner: set to Jean-Paul Calderone

Awesome, please merge.

comment:14 Changed 8 years ago by Jean-Paul Calderone

Branch: branches/remove-woven-1522branches/remove-woven-1522-2

(In [25918]) Branching to 'remove-woven-1522-2'

comment:15 Changed 8 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [25924]) Merge remove-woven-1522-2

Author: exarkun Reviewer: therve Fixes: #1522

Remove twisted.web.woven and all remaining code which used anything from that package as well as the documentation for Woven.

comment:16 Changed 6 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.