Ticket #1089 defect closed fixed

Opened 9 years ago

Last modified 6 years ago

http proxy doesn't close connection after sending 'Could not connect'

Reported by: jeffsilver Owned by: therve
Priority: highest Milestone:
Component: web Keywords:
Cc: jknight, jeffsilver Branch:
Author: Launchpad Bug:

Description


Attachments

1089.diff Download (0.9 KB) - added by therve 6 years ago.

Change History

1

Changed 9 years ago by jeffsilver

In web/proxy.py, ProxyClientFactory.clientConnectionFailed(), an error page is
sent to the client, but the connection is not closed.
I think this can be fixed by inserting:
    self.father.transport.loseConnection()
at the end of the method (but I'm not certain that this is clean).

2

Changed 9 years ago by jeffsilver

I've included this fix in my patch for #1149

3

Changed 6 years ago by therve

  • component set to conch

#2922 has been closed as a duplicate of this.

4

Changed 6 years ago by therve

  • owner changed from jknight to therve
  • component changed from conch to web

Changed 6 years ago by therve

5

Changed 6 years ago by therve

  • priority changed from high to highest
  • owner therve deleted
  • keywords review added

I think that doesn't deserver a branch :). Ready to review.

6

Changed 6 years ago by exarkun

  • keywords review removed
  • owner set to therve

Beautiful, please merge.

7

Changed 6 years ago by therve

  • status changed from new to closed
  • resolution set to fixed

(In [22159]) Close connection twisted.web.proxy.ProxyClientFactory when reporting a 501 error.

Author: therve Reviewer: exarkun Fixes #1089

Note: See TracTickets for help on using tickets.