Changeset 27710

Timestamp:

12/08/2009 06:25:08 AM (9 months ago)

Author:

jml

Message:

Comprehensive, direct test coverage of SubunitReporter.

refs #4004

Files:

• branches/subunit-4004/twisted/trial/test/test_reporter.py (modified) (3 diffs)

branches/subunit-4004/twisted/trial/test/test_reporter.py

@@ -936 +936 @@
         done() is called when the test suite is done.
         """
+        # XXX: Drop this and replace with verifyObject
         self.result.done()
 
@@ -1177 +1178 @@
 
 
+    def assertForwardsToSubunit(self, methodName, *args, **kwargs):
+        """
+        Assert that 'methodName' on L{SubunitReporter} forwards to the
+        equivalent method on subunit.
+
+        Checks that the return value from subunit is returned from the
+        L{SubunitReporter} and that the reporter writes the same data to its
+        stream as subunit does to its own.
+
+        Assumes that the method on subunit has the same name as the method on
+        L{SubunitReporter}.
+        """
+        stream = StringIO.StringIO()
+        subunitClient = reporter.TestProtocolClient(stream)
+        subunitReturn = getattr(subunitClient, methodName)(*args, **kwargs)
+        subunitOutput = stream.getvalue()
+        reporterReturn = getattr(self.result, methodName)(*args, **kwargs)
+        self.assertEqual(subunitReturn, reporterReturn)
+        self.assertEqual(subunitOutput, self.stream.getvalue())
+
+
     def test_oldSubunitInstalled(self):
         """
@@ -1220 +1242 @@
 
 
+    def test_doneDoesNothing(self):
+        """
+        The subunit reporter doesn't need to print out a summary -- the stream
+        of results is everything. Thus, done() does nothing.
+        """
+        self.result.done()
+        self.assertEqual('', self.stream.getvalue())
+
+
+    def test_startTest_sends_subunit_startTest(self):
+        """
+        SubunitReporter.startTest() sends the subunit 'startTest' message.
+        """
+        self.assertForwardsToSubunit('startTest', self.test)
+
+
+    def test_stopTest_sends_subunit_stopTest(self):
+        """
+        SubunitReporter.stopTest() sends the subunit 'stopTest' message.
+        """
+        self.assertForwardsToSubunit('stopTest', self.test)
+
+
+    def test_addSuccess_sends_subunit_addSuccess(self):
+        """
+        SubunitReporter.addSuccess() sends the subunit 'addSuccess' message.
+        """
+        self.assertForwardsToSubunit('addSuccess', self.test)
+
+
+    def test_addSkip_sends_subunit_addSkip(self):
+        """
+        SubunitReporter.addSkip() sends the subunit 'addSkip' message.
+        """
+        self.assertForwardsToSubunit('addSkip', self.test, 'reason')
+
+
+    def test_addError_sends_subunit_addError(self):
+        """
+        SubunitReporter.addError() sends the subunit 'addError' message.
+        """
+        try:
+            1 / 0
+        except ZeroDivisionError:
+            error = sys.exc_info()
+        self.assertForwardsToSubunit('addError', self.test, error)
+
+
+    def test_addFailure_sends_subunit_addFailure(self):
+        """
+        SubunitReporter.addFailure() sends the subunit 'addFailure' message.
+        """
+        try:
+            self.fail('hello')
+        except self.failureException:
+            failure = sys.exc_info()
+        self.assertForwardsToSubunit('addFailure', self.test, failure)
+
+
+    def test_addUnexpectedSuccess_sends_subunit_addSuccess(self):
+        """
+        SubunitReporter.addFailure() sends the subunit 'addSuccess' message,
+        since subunit doesn't model unexpected success.
+        """
+        stream = StringIO.StringIO()
+        subunitClient = reporter.TestProtocolClient(stream)
+        subunitClient.addSuccess(self.test)
+        subunitOutput = stream.getvalue()
+        self.result.addUnexpectedSuccess(self.test, 'todo')
+        self.assertEqual(subunitOutput, self.stream.getvalue())
+
+
+
 class TestSubunitReporterNotInstalled(unittest.TestCase):
     """