Changeset 27709

Timestamp:

12/08/2009 03:25:29 AM (9 months ago)

Author:

jonathanj

Message:

Address review commentary. refs #3296

Location:

branches/isupport-aware-mode-parsing-3296/twisted/words

Files:

• protocols/irc.py (modified) (2 diffs)
• test/test_irc.py (modified) (2 diffs)

branches/isupport-aware-mode-parsing-3296/twisted/words/protocols/irc.py

@@ -1747 +1747 @@
         """
         channel, modes, args = params[0], params[1], params[2:]
-        
+
         if modes[0] not in '-+':
             modes = '+' + modes
@@ -1761 +1761 @@
             added, removed = parseModes(modes, args, paramModes)
         except IRCBadModes:
-            log.msg('An error occured while parsing the following MODE message:'
-                    ' MODE %s' % (' '.join(params),))
-            log.err()
+            log.err(None, 'An error occured while parsing the following '
+                          'MODE message: MODE %s' % (' '.join(params),))
         else:
             if added:

branches/isupport-aware-mode-parsing-3296/twisted/words/test/test_irc.py

@@ -884 +884 @@
 
 
-    def testISupport(self):
+    def test_ISUPPORT(self):
+        """
+        The client parses ISUPPORT messages sent by the server and calls
+        L{IRCClient.isupport}.
+        """
         self._sendISUPPORT()
 
@@ -1075 +1079 @@
     def test_modeMissingDirection(self):
         """
-        Mode strings that do not begin with a directional character, C{+} or
-        C{-}, have C{+} automatically prepended.
+        Mode strings that do not begin with a directional character, C{'+'} or
+        C{'-'}, have C{'+'} automatically prepended.
         """
         self._sendModeChange('s')