Ticket #6168: 6168.diff

twisted/web/http_headers.py

@@ -194 +194 @@
 
         @return: C{None}
         """
+
         if not isinstance(values, list):
             raise TypeError("Header entry %r should be list but found "
                             "instance of %r instead" % (name, type(values)))
+
+        if not all(isinstance(n, bytes) for n in name):
+            raise TypeError("All header elements in %r must be bytes" % name )
+
         self._rawHeaders[name.lower()] = values
 
 

twisted/web/test/test_http.py

@@ -1375 +1375 @@
             "Passing non-bytes header values is deprecated since "
             "Twisted 12.3. Pass only bytes instead.")
 
+    def test_nonByteHeaderError(self):
+        """
+        L{http.Request.write} casts non-bytes header value to bytes
+        transparently.
+        """
+        req = http.Request(DummyChannel(), None)
+
+        intlist = [int(1), int(2)]
+        err = self.assertRaises(TypeError, req.responseHeaders.setRawHeaders, intlist, [10])
+        self.assertEqual(str(err), "All header elements in " + intlist.__str__() + " must be bytes")     
 
     def test_firstWriteHTTP11Chunked(self):
         """