Ticket #5726: dont-open-console-window-v2.diff

twisted/internet/_dumbwin32proc.py

@@ -172 +172 @@
         cmdline = quoteArguments(args)
         # TODO: error detection here.  See #2787 and #4184.
         def doCreate():
+            flags = win32con.CREATE_NO_WINDOW
             self.hProcess, self.hThread, self.pid, dwTid = win32process.CreateProcess(
-                command, cmdline, None, None, 1, 0, env, path, StartupInfo)
+                command, cmdline, None, None, 1, flags, env, path, StartupInfo)
         try:
             try:
                 doCreate()

twisted/test/test_process.py

@@ -27 +27 @@
 from twisted.python.log import msg
 from twisted.internet import reactor, protocol, error, interfaces, defer
 from twisted.trial import unittest
-from twisted.python import util, runtime, procutils
+from twisted.python import filepath, util, runtime, procutils
 from twisted.python.compat import set
 
 
@@ -2350 +2350 @@
 
 
 
+class Win32CreateProcessFlagsTest(unittest.TestCase):
+    """
+    Check the flags passed to CreateProcess.
+    """
+
+    @defer.inlineCallbacks
+    def test_flags(self):
+        """
+        Verify that the flags passed to win32process.CreateProcess() prevent a
+        new console window from being created. See bug #5726 for a script to
+        test this interactively.
+        """
+        from twisted.internet import _dumbwin32proc
+        flags = []
+        real_CreateProcess = _dumbwin32proc.win32process.CreateProcess
+
+        def fake_createprocess(_appName, _commandLine, _processAttributes,
+                            _threadAttributes, _bInheritHandles, creationFlags,
+                            _newEnvironment, _currentDirectory, startupinfo):
+            """Store the creationFlags for later comparing."""
+            flags.append(creationFlags)
+            return real_CreateProcess(_appName, _commandLine,
+                            _processAttributes, _threadAttributes,
+                            _bInheritHandles, creationFlags, _newEnvironment,
+                            _currentDirectory, startupinfo)
+
+        self.patch(_dumbwin32proc.win32process, "CreateProcess",
+                   fake_createprocess)
+        exe = sys.executable
+        scriptPath = filepath.FilePath(__file__).sibling("process_cmdline.py")
+
+        d = defer.Deferred()
+        processProto = TrivialProcessProtocol(d)
+        comspec = str(os.environ["COMSPEC"])
+        cmd = [comspec, "/c", exe, scriptPath.path]
+        _dumbwin32proc.Process(reactor, processProto, None, cmd, {}, None)
+        yield d
+        self.assertEqual(flags,
+                         [_dumbwin32proc.win32process.CREATE_NO_WINDOW])
+
+
+
 class UtilTestCase(unittest.TestCase):
     """
     Tests for process-related helper functions (currently only
@@ -2553 +2595 @@
     Win32ProcessTestCase.skip = skipMessage
     TestTwoProcessesNonPosix.skip = skipMessage
     Dumbwin32procPidTest.skip = skipMessage
+    Win32CreateProcessFlagsTest.skip = skipMessage
     Win32UnicodeEnvironmentTest.skip = skipMessage
 
 if not interfaces.IReactorProcess(reactor, None):

twisted/topfiles/5726.bugfix

@@ +1 @@
+spawnProcess no longer opens an unwanted console on Windows