Ticket #4963: 4963.patch

twisted/mail/test/test_mail.py

@@ -2008 +2008 @@
 
 
 
-
-
-
 class TestDomain:
     def __init__(self, aliases, users):
         self.aliases = aliases
@@ -2031 +2028 @@
             raise smtp.SMTPBadRcpt(user)
 
 
+
+class SSLContextFactoryTests(unittest.TestCase):
+    """
+    Tests for twisted.mail.protocols.SSLContextFactory.
+    """
+
+
+    def testDeprecation(self):
+        """
+        Test deprecation of twisted.mail.protocols.SSLContextFactory.
+        """
+        mail.protocols.SSLContextFactory('')
+        warningsShown = self.flushWarnings([self.testDeprecation])
+        self.assertEqual(len(warningsShown), 1)
+        self.assertIdentical(warningsShown[0]['category'], DeprecationWarning)
+        self.assertEqual(warningsShown[0]['message'], 'twisted.mail.protocols.SSLContextFactory was deprecated in Twisted 12.1.0: Use twisted.internet.ssl.DefaultOpenSSLContextFactory instead.')
+
 from twisted.python.runtime import platformType
 import types
 if platformType != "posix":

twisted/mail/topfiles/4963.removal

@@ +1 @@
+twisted.mail.protocols.SSLContextFactory is now deprecated.

twisted/mail/protocols.py

@@ -12 +12 @@
 from twisted.internet import defer
 from twisted.copyright import longversion
 from twisted.python import log
+from twisted.python.deprecate import deprecatedModuleAttribute
+from twisted.python.versions import Version
 
 from twisted import cred
 import twisted.cred.error
@@ -213 +215 @@
     
     This loads a certificate and private key from a specified file.
     """
+
+    deprecatedModuleAttribute(Version("Twisted", 12, 1, 0), "Use twisted.internet.ssl.DefaultOpenSSLContextFactory instead.", "twisted.mail.protocols", "SSLContextFactory")
+
+
     def __init__(self, filename):
         self.filename = filename