Ticket #4937: locale-independent-formatting-with-tests.patch

twisted/conch/ls.py

@@ -7 +7 @@
 
 from time import time, strftime, localtime
 
+# locale-independent month names to use instead of strftime's
+MONTH_NAMES = dict(zip(range(1, 13),
+                   "Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec".split()))
+
 
 def lsLine(name, s):
     mode = s.st_mode
@@ -39 +43 @@
     if mode&stat.S_ISGID:
         if perms[6] == 'x': perms[6] = 's'
         else: perms[6] = 'S'
-    l = perms.tostring()
-    l += str(s.st_nlink).rjust(5) + ' '
+
     un = str(s.st_uid)
-    l += un.ljust(9)
     gr = str(s.st_gid)
-    l += gr.ljust(9)
     sz = str(s.st_size)
-    l += sz.rjust(8)
-    l += ' '
     sixmo = 60 * 60 * 24 * 7 * 26
+    l = [perms.tostring(), str(s.st_nlink).rjust(5), ' ',
+         un.ljust(9), gr.ljust(9), sz.rjust(8), ' ']
+
+    # need to specify the month manually, as strftime depends on locale
+    ttup = localtime(s.st_mtime)
     if s.st_mtime + sixmo < time(): # last edited more than 6mo ago
-        l += strftime("%b %d  %Y ", localtime(s.st_mtime))
+        strtime = strftime("%%s %d  %Y ", ttup)
     else:
-        l += strftime("%b %d %H:%M ", localtime(s.st_mtime))
-    l += name
-    return l
+        strtime = strftime("%%s %d %H:%M ", ttup)
+    l.append(strtime % (MONTH_NAMES[ttup[1]],))
+
+    l.append(name)
+    return ''.join(l)
 
 
 __all__ = ['lsLine']

twisted/conch/test/test_cftp.py

@@ -6 +6 @@
 Tests for L{twisted.conch.scripts.cftp}.
 """
 
+import locale
 import time, sys, os, operator, getpass, struct
 from StringIO import StringIO
 
 from twisted.conch.test.test_ssh import Crypto, pyasn1
+from twisted.python import runtime
 
 _reason = None
 if Crypto and pyasn1:
@@ -142 +144 @@
             '!---------    0 0        0               0 Aug 29 09:33 foo')
 
 
+    def test_localeIndependent(self):
+        """
+        The month name in the date should be locale independent.
+        """
+        # A point about three months in the past.
+        then = self.now - (60 * 60 * 24 * 31 * 3)
+        stat = os.stat_result((0, 0, 0, 0, 0, 0, 0, 0, then, 0))
+
+        # Fake that we're in a language where August is not Aug (e.g.: Spanish)
+        current_locale = locale.getlocale()
+        locale.setlocale(locale.LC_ALL, "es_AR.UTF8")
+        self.addCleanup(locale.setlocale, locale.LC_ALL, current_locale)
+
+        self.assertEqual(
+            self._lsInTimezone('America/New_York', stat),
+            '!---------    0 0        0               0 Aug 28 17:33 foo')
+        self.assertEqual(
+            self._lsInTimezone('Pacific/Auckland', stat),
+            '!---------    0 0        0               0 Aug 29 09:33 foo')
+
+    if runtime.platform.isWindows():
+        test_localeIndependent.skip = "No es_AR.UTF8 locale in Windows."
+
+
     def test_newSingleDigitDayOfMonth(self):
         """
         A file with a high-resolution timestamp which falls on a day of the

twisted/mail/imap4.py

@@ -49 +49 @@
 import twisted.cred.credentials
 
 
+# locale-independent month names to use instead of strftime's
+MONTH_NAMES = dict(zip(range(1, 13),
+                   "Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec".split()))
 
 class MessageSet(object):
     """
@@ -1904 +1907 @@
             log.msg("%d:%r: unpareseable internaldate: %r" % (id, msg, idate))
             raise IMAP4Exception("Internal failure generating INTERNALDATE")
 
-        odate = time.strftime("%d-%b-%Y %H:%M:%S ", ttup[:9])
+        # need to specify the month manually, as strftime depends on locale
+        strdate = time.strftime("%d-%%s-%Y %H:%M:%S ", ttup[:9])
+        odate = strdate % (MONTH_NAMES[ttup[1]],)
         if ttup[9] is None:
             odate = odate + "+0000"
         else:

twisted/mail/test/test_imap.py

@@ -12 +12 @@
 except ImportError:
     from StringIO import StringIO
 
+import codecs
+import locale
 import os
 import types
-import codecs
 
 from zope.interface import implements
 
@@ -29 +30 @@
 from twisted.trial import unittest
 from twisted.python import util
 from twisted.python import failure
+from twisted.python import runtime
 
 from twisted import cred
 import twisted.cred.error
@@ -3461 +3463 @@
     def testFetchInternalDateUID(self):
         return self.testFetchInternalDate(1)
 
+    def testFetchInternalDateLocaleIndependent(self):
+        """
+        The month name in the date should be locale independent.
+        """
+        # Fake that we're in a language where December is not Dec
+        current_locale = locale.getlocale()
+        locale.setlocale(locale.LC_ALL, "es_AR.UTF8")
+        self.addCleanup(locale.setlocale, locale.LC_ALL, current_locale)
+        return self.testFetchInternalDate(1)
+
+    if runtime.platform.isWindows():
+        testFetchInternalDateLocaleIndependent.skip = """
+            No es_AR.UTF8 locale in Windows.
+        """
+
     def testFetchEnvelope(self, uid=0):
         self.function = self.client.fetchEnvelope
         self.messages = '15'