Ticket #4386: 4386.2.patch

twisted/topfiles/4386.bugfix

@@ +1 @@
+twisted.internet.abstract.FileDescriptor implements twisted.internet.interfaces.IPushProducer instead of twisted.internet.interfaces.IProducer.

twisted/internet/abstract.py

@@ -155 +155 @@
 
     SEND_LIMIT = 128*1024
 
-    implements(interfaces.IProducer, interfaces.IReadWriteDescriptor,
+    implements(interfaces.IPushProducer, interfaces.IReadWriteDescriptor,
                interfaces.IConsumer, interfaces.ITransport, interfaces.IHalfCloseableDescriptor)
 
     def __init__(self, reactor=None):

twisted/internet/test/test_filedescriptor.py

@@ -5 +5 @@
 Whitebox tests for L{twisted.internet.abstract.FileDescriptor}.
 """
 
+from zope.interface.verify import verifyClass
+
 from twisted.internet.abstract import FileDescriptor
+from twisted.internet.interfaces import IPushProducer
 from twisted.trial.unittest import TestCase
 
 
 
-class FileDescriptorWriteSequenceTests(TestCase):
+class FileDescriptorTests(TestCase):
     """
-    Tests for L{FileDescriptor.writeSequence}.
+    Tests for L{FileDescriptor}.
     """
     def test_writeWithUnicodeRaisesException(self):
         """
@@ -29 +32 @@
         fileDescriptor = FileDescriptor()
         self.assertRaises(
             TypeError, fileDescriptor.writeSequence, ['foo', u'bar', 'baz'])
+
+
+    def test_fileDescriptorImplementsIPushProducer(self):
+        """
+        L{FileDescriptor} implements L{IPushProducer}
+        """
+        self.assertTrue(verifyClass(IPushProducer, FileDescriptor))