Ticket #4022: strict-setRawHeaders-4022.diff

twisted/web/test/test_http_headers.py

@@ -37 +37 @@
         self.assertTrue(h.hasHeader("Test"))
         self.assertEqual(h.getRawHeaders("test"), rawValue)
 
+    def test_rawHeadersTypeChecking(self):
+        """
+        L{Headers.setRawHeaders} requires values to be of type list.
+        """
+        h = Headers()
+        self.assertRaises(TypeError, h.setRawHeaders, {'Foo': 'bar'})
 
     def test_addRawHeader(self):
         """

twisted/web/http_headers.py

@@ -196 +196 @@
 
         @return: C{None}
         """
+        if not isinstance(values, list):
+            raise TypeError("Header entry `%r' should be list but found"
+                            " %r instead" % (name, type(values)))
         self._rawHeaders[name.lower()] = values