Ticket #4021: twisted-lesschatty.patch

twisted/internet/udp.py

@@ -93 +93 @@
         # Make sure that if we listened on port 0, we update that to
         # reflect what the OS actually assigned us.
         self._realPortNumber = skt.getsockname()[1]
+        
+        if self.protocol.noisy:
+            log.msg("%s starting on %s"%(self.protocol.__class__, self._realPortNumber))
 
-        log.msg("%s starting on %s"%(self.protocol.__class__, self._realPortNumber))
-
         self.connected = 1
         self.socket = skt
         self.fileno = self.socket.fileno
@@ -200 +201 @@
     def connectionLost(self, reason=None):
         """Cleans up my socket.
         """
-        log.msg('(Port %s Closed)' % self._realPortNumber)
+        if self.protocol.noisy:
+            log.msg('(Port %s Closed)' % self._realPortNumber)
         self._realPortNumber = None
         base.BasePort.connectionLost(self, reason)
         if hasattr(self, "protocol"):

twisted/internet/tcp.py

@@ -857 +857 @@
         # Make sure that if we listened on port 0, we update that to
         # reflect what the OS actually assigned us.
         self._realPortNumber = skt.getsockname()[1]
+        if self.factory.noisy:
+            log.msg("%s starting on %s" % (self.factory.__class__, self._realPortNumber))
 
-        log.msg("%s starting on %s" % (self.factory.__class__, self._realPortNumber))
-
         # The order of the next 6 lines is kind of bizarre.  If no one
         # can explain it, perhaps we should re-arrange them.
         self.factory.doStart()

twisted/internet/protocol.py

@@ -34 +34 @@
     protocol = None
 
     numPorts = 0
-    noisy = True
+    noisy = False
 
     def doStart(self):
         """Make sure startFactory is called.
@@ -516 +516 @@
 
     transport = None
     numPorts = 0
-    noisy = True
+    noisy = False
 
     def __getstate__(self):
         d = self.__dict__.copy()