<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Courier;
panose-1:2 7 4 9 2 2 5 2 4 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:Arial;
color:windowtext;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
/* List Definitions */
@list l0
{mso-list-id:2144692884;
mso-list-type:hybrid;
mso-list-template-ids:1542256578 67698705 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-text:"%1\)";
mso-level-tab-stop:.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-tab-stop:1.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level4
{mso-level-tab-stop:2.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-tab-stop:2.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-tab-stop:3.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level7
{mso-level-tab-stop:3.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-tab-stop:4.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-tab-stop:4.5in;
mso-level-number-position:left;
text-indent:-.25in;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
-->
</style>
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>This bug has occurs when a client request partial content
of a static.File resource.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>There are three problems.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'><o:p> </o:p></span></font></p>
<p class=MsoNormal style='margin-left:.5in;text-indent:-.25in;mso-list:l0 level1 lfo1'><![if !supportLists]><font
size=2 face=Courier><span style='font-size:10.0pt;font-family:Courier'><span
style='mso-list:Ignore'>1)<font size=1 face="Times New Roman"><span
style='font:7.0pt "Times New Roman"'> </span></font></span></span></font><![endif]><font
size=2 face=Courier><span style='font-size:10.0pt;font-family:Courier'>The
Content-Length header value is off by 1. For example a request with a
Range: bytes=0-1999 would yield Content-Length of 1999 when it should actually
be Content-Length: 2000.<o:p></o:p></span></font></p>
<p class=MsoNormal style='margin-left:.5in;text-indent:-.25in;mso-list:l0 level1 lfo1'><![if !supportLists]><font
size=2 face=Courier><span style='font-size:10.0pt;font-family:Courier'><span
style='mso-list:Ignore'>2)<font size=1 face="Times New Roman"><span
style='font:7.0pt "Times New Roman"'> </span></font></span></span></font><![endif]><font
size=2 face=Courier><span style='font-size:10.0pt;font-family:Courier'>The
Content-Range response header was generated incorrectly. For example the
request with a Range: bytes=0-1999 header for a file of 100000 bytes in size
would yield a Content-Range header like Content-Range: bytes 0-1999/1999,
when it should be Content-Range: bytes 0-1999/100000.<o:p></o:p></span></font></p>
<p class=MsoNormal style='margin-left:.5in;text-indent:-.25in;mso-list:l0 level1 lfo1'><![if !supportLists]><font
size=2 face=Courier><span style='font-size:10.0pt;font-family:Courier'><span
style='mso-list:Ignore'>3)<font size=1 face="Times New Roman"><span
style='font:7.0pt "Times New Roman"'> </span></font></span></span></font><![endif]><font
size=2 face=Courier><span style='font-size:10.0pt;font-family:Courier'>The
ASISProcessor incorrectly instantiated the File instance by passing a registry
parameter to the defaultType argument.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>The diffs are as follows:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>diff –u static.py.orig static.py<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>--- static.py.orig
2005-02-09 18:52:35.422310000 -0800<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+++ static.py 2005-02-09
19:11:23.181906600 -0800<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>@@ -319,7 +319,7 @@<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
return self.redirect(request)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> #for
content-length<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>- fsize = size =
self.getFileSize()<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+ fsize = csize
= self.getFileSize()<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
request.setHeader('accept-ranges','bytes')<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>@@ -350,20 +350,19 @@<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
"Syntactically invalid http range header!"<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
start, end = string.split(bytesrange[1],'-')<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
if start:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
f.seek(int(start))<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
start = int(start)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
f.seek(start)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
if end:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
end = int(end)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
size = end<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
csize = int(end) - start + 1<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
else:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
end = size<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
csize -= start<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
request.setResponseCode(http.PARTIAL_CONTENT)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
request.setHeader('content-range',"bytes %s-%s/%s " % (<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
str(start), str(end), str(size)))<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
#content-length should be the actual size of the stuff we're<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
#sending, not the full size of the on-server entity.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
fsize = end - int(start)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
request.setHeader('content-range',"bytes %s-%s/%s " % \<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
(start, end, fsize))<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
#content-length should be the actual size of the stuff we're<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
#sending, not the full size of the on-server entity.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
request.setHeader('content-length', str(csize))<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
request.setHeader('content-length', str(fsize))<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> except:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
traceback.print_exc(file=log.logfile)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>@@ -371,7 +370,7 @@<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
return ''<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> # return
data<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
FileTransfer(f, size, request)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
FileTransfer(f, csize, request)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> # and
make sure the connection doesn't get closed<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> return
server.NOT_DONE_YET<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>@@ -422,17 +421,16 @@<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> self.file
= file<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> self.size
= size<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
self.request = request<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>- self.written =
self.file.tell()<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
request.registerProducer(self, 0)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> def resumeProducing(self):<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> if not
self.request:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
return<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>- data =
self.file.read(min(abstract.FileDescriptor.bufferSize, self.size -
self.written))<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+ data =
self.file.read(min(abstract.FileDescriptor.bufferSize, self.size))<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> if data:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>-
self.written += len(data)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
self.request.write(data)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>- if self.file.tell()
== self.size:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+
self.size -= len(data)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+ if self.size
<= 0:<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
self.request.unregisterProducer()<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
self.request.finish()<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
self.request = None<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>@@ -473,5 +471,5 @@<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> <o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> def render(self, request):<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>
request.startedWriting = 1<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>- res =
static.File(self.path, self.registry)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'>+ res =
static.File(self.path, registry=self.registry)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Courier><span style='font-size:10.0pt;
font-family:Courier'> return
res.render(request)<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face=Arial><span style='font-size:10.0pt;
font-family:Arial'><o:p> </o:p></span></font></p>
</div>
</body>
</html>