[Twisted-web] FileSaver bug

[Cory Dodt]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Alex,

Please submit a bug at <http://twistedmatrix.com/trac>.  The fix for this one
is trivial, but it also needs a failing unit test.  (The current tests would
never have noticed this bug, which is indeed serious.)


C


Alex Greif wrote:
> Hi
> 
> On windows XP (python 2.4.2) the latest svn checkout produces the
> following bug:
> FileSaver converts LF to CRLF automatically, even in binary files!!
> 
> I tried to upload files with the following code:
> 
>  child_uploadfile = static.FileSaver(destination='d:/agreif/tmp',
>                                                expectedFields=['filename'],
>                                                maxBytes=10000000,
> 
> allowedTypes=[http_headers.MimeType('text', 'x-python'),
> 
> http_headers.MimeType('application','x-zip-compressed')])
> 
> here is the hexdump of two samples.
> You see that in front of every occurrance of "0A" a "0D" is inserted.
> 
> Sample 1: textfile
> orig:
> 68616C6C6F0A
> uploaded:
> 68616C6C6F0D0A
> 
> Sample 2 binary file (zip)
> orig:
> 504B03040A00000000001589FF34D13172B90500000005000000100000004E6575205465787464617465692E707968616C6C6F504B010214000A00000000001589FF34D13172B905000000050000001000000000000000010020000000000000004E6575205465787464617465692E7079504B050600000000010001003E000000330000000000
> 
> uploaded:
> 504B03040D0A00000000001589FF34D13172B90500000005000000100000004E6575205465787464617465692E707968616C6C6F504B010214000D0A00000000001589FF34D13172B905000000050000001000000000000000010020000000000000004E6575205465787464617465692E7079504B050600000000010001003E000000330000000000
> 
> 
> 
> Alex.
> 
> _______________________________________________
> Twisted-web mailing list
> Twisted-web at twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-web

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEzjOR3A5SrXAiHQcRAjQMAJ49Y983MMvo/Quq3rnH3PGhvcIQWwCghSJY
yXe/AiGyNMl/63jTfjZpqSE=
=EEfu
-----END PGP SIGNATURE-----