[Twisted-web] Athena closed the live connection when escape is hit

Cory Dodt corydodt+hello at gmail.com
Mon Dec 4 16:25:51 CST 2006


Can't we just stopPropagation/preventDefault on keycode 27?

C


On 12/4/06, Phil Mayers <p.mayers at imperial.ac.uk> wrote:
>
> glyph at divmod.com wrote:
> > On 12:31 am, p.mayers at imperial.ac.uk wrote:
> >  >Jean-Paul Calderone wrote:
> >  >>On Mon, 04 Dec 2006 00:08:05 +0000, Phil Mayers
> > <p.mayers at imperial.ac.uk>
> >  >>wrote:
> >  >>>Why?
> >  >>>
> >  >>>
> http://divmod.org/trac/browser/trunk/Nevow/nevow/js/Nevow/Athena/__init__.js#L570
> >  >>
> >  >>Lack of time to implement something different.
> >  >
> >  >Ok, I guess what I'm asking is - why is it ever necessary for the
> > client to
> >  >execute a close of the live connection via the keyboard (other than
> >  >debugging of course) and will anything break if I comment that out?
> >  >
> >  >I'm guessing not.
> >
> > If escape isn't handled, then sometimes it will invoke the "stop"
> > button, which causes random non-deterministic connection failures which
> > aren't immediately reported.  I don't entirely understand the situation,
> > but an immediate failure is better than what was happening before.
> >
> > I believe this is actually fixable, but as JP says, we don't have time
> > at the moment.
>
> Hrm. Interesting. Ok. It's hardly a critical problem, thanks for taking
> the time to reply (FWIW I was handling escape to trigger closure of an
> autocomplete dropdown <div>)
>
> Do you happen to know what browsers the escape==stop behaviour occurs
> under? I might take a look at it.
>
> _______________________________________________
> Twisted-web mailing list
> Twisted-web at twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-web
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://twistedmatrix.com/pipermail/twisted-web/attachments/20061204/90662b8b/attachment.htm


More information about the Twisted-web mailing list