<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>On Apr 3, 2014, at 1:13 AM, Adi Roiban <<a href="mailto:adi@roiban.ro">adi@roiban.ro</a>> wrote:</div><div><br class="Apple-interchange-newline"><blockquote type="cite">Hi,<br><br>Reading the producer/consumer docs I first found out that<br><br>IFinishableConsumer api link is broken (link to twisted.internet.interfaces):<br><a href="http://twistedmatrix.com/documents/current/core/howto/producers.html#auto7">http://twistedmatrix.com/documents/current/core/howto/producers.html#auto7</a><br><br>Then I found out that IFinishableConsumer is defined in<br>twisted.protocols.ftp.IFinishableConsumer<br><br>I was expecting to see the interface defined in twisted.internet.interfaces .<br><br>Should the broken link be fixed or interfaced moved ?<br><br>I think that moving the interface should be safe, as old imports will<br>still work.<br></blockquote></div><br><div>Given that:</div><div><br></div><div> 1. this interface has apparently worked this way for a <i>long</i> time,</div><div> 2. work to overhaul these interfaces is ongoing in the 'tubes' branch </div><div> 3. apparently nobody was using that method anyway since this is the first complaint I'm aware of</div><div><br></div><div>I think the docs should be changed to reflect reality rather than the other way around. We can just remove the mention of IFinishableConsumer and document that in FTP.</div><div><br></div><div>-glyph</div></body></html>