<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Feb 20, 2014, at 6:00 AM, Adi Roiban <<a href="mailto:adi@roiban.ro">adi@roiban.ro</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>While submitting a patch on Twisted I got a review response that my code is not complaint with `twistedchecker`.</div><div><br></div><div>My first reaction was: Holy code, what is twistedchecker!</div></div></blockquote><div><br></div><div>As new tools are added to our development process to make things easier (the things twistedchecker checks for used to be entirely manual) it's an ongoing struggle to keep our documentation up to date.</div><div><br></div><blockquote type="cite"><div dir="ltr">Now that I got some info about twistedchecker and wiki write access I would like to update the <a href="https://twistedmatrix.com/trac/wiki/TwistedDevelopment">https://twistedmatrix.com/trac/wiki/TwistedDevelopment</a> wiki page with information about how a Twisted developer is expected to use twistedchecker.</div></blockquote><div><br></div><div>Please do!</div><br><blockquote type="cite"><div dir="ltr"><div>I run twistedcheck on trunk and got a lot of errors.</div></div></blockquote><div><br></div><div>Yes.</div><div><br></div><div>Because the things twistedchecker checks for used to be manual, we used to fail to check for a lot of them. And many of the things it checks for were not even thought of when Twisted was first developed. This means that the codebase is largely not compliant with twistedchecker.</div><div><br></div><blockquote type="cite"><div dir="ltr"><div>Am I suppose to look through all those error and filter the ones generated by my changes?</div></div></blockquote><div><br></div><div>Yes and no.</div><div><br></div><div>Yes, in that you should only care about the new ones that your changes created. We aim to have the number of twistedchecker warnings decreasing over time; but as long as trunk still produces hundreds and hundreds of warnings we're never going to have a big project to eliminate them in one fell swoop.</div><div><br></div><div>No, in that you don't have to do this yourself, the buildbot will do it for you. For example, if on the page for this build <<a href="http://buildbot.twistedmatrix.com/builders/twistedchecker/builds/1815">http://buildbot.twistedmatrix.com/builders/twistedchecker/builds/1815</a>> you click on "new twistedchecker errors", you will see <<a href="http://buildbot.twistedmatrix.com/builders/twistedchecker/builds/1815/steps/run-twistedchecker/logs/new twistedchecker errors">http://buildbot.twistedmatrix.com/builders/twistedchecker/builds/1815/steps/run-twistedchecker/logs/new%20twistedchecker%20errors</a>> a very small number of warnings. If there are no <i>new </i>twistedchecker errors, the builds should succeed. (This mechanism isn't perfect, however; sometimes it fails, although less now than it used to.)</div><br><blockquote type="cite"><div dir="ltr"><div>Since twistedchecker is only about twisted, shouldn't it be included as a dependency to twisted-dev-tools so that as I developer I would only need to install one extra package and it will pull all development/testing depenencies?</div></div></blockquote><div><br></div><div>Sounds like a good idea to me.</div><br><blockquote type="cite"><div dir="ltr"><div><div>Thanks!</div></div></div></blockquote><br></div><div>Thank you for pointing this out!</div><div><br></div><div>-glyph</div><div><br></div><br></body></html>