<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">On Sep 17, 2013, at 10:43 AM, Phil Mayers <<a href="mailto:p.mayers@imperial.ac.uk">p.mayers@imperial.ac.uk</a>> wrote:<br><div><br class="Apple-interchange-newline"><blockquote type="cite">On 17/09/13 17:05, <a href="mailto:exarkun@twistedmatrix.com">exarkun@twistedmatrix.com</a> wrote:<br><br><blockquote type="cite"><blockquote type="cite">p.s. the "How to review" docs on Trac are AWFUL if you've never done<br>one before. It assumes a *hell* of a lot of prior knowledge. There<br>needs to be a single page checklist for first-time reviewers.<br></blockquote><br>This is in progress.<br></blockquote><br>Awesome; would it be useful for me to write up what I did, or do you have enough source material?<br></blockquote><div><br></div><div>Let's have a discussion here on the list first :-). So... yes, write it up in a reply.</div><div><br></div><div>The review docs are always in progress. Feedback like "this is bad" is basically useless; we know it's bad, but everyone has its own idea of what "bad" means. What would be really useful in such a write-up was specific feedback about what you needed to know, what resources you discovered, and what they were missing. Like:</div><div><br></div></div><blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"><div><div>"I didn't know if I should _ or _ because I was looking at this url _ and it didn't say and didn't link to anything that told me what to do. So, based on this previous review _ I decided to _ and that worked out okay, that should be documented on the first URL I found".</div></div></blockquote><div><br></div><div>So please feel free to offer more feedback but let's please keep it as specific as possible.</div><div><br><blockquote type="cite">FWIW I found virtualenv & the github mirror to be incredibly useful for the task; in particular it meant getting latest & greatest pyflakes/twistedchecker and dependencies, and being able to install the branch.</blockquote><br></div><div>Separately, "how to get set up to review" would be a useful document too.</div><div><br></div><div>-glyph</div><div><br></div></body></html>