<html><head></head><body bgcolor="#FFFFFF"><div><br><br>On Oct 21, 2012, at 7:02 AM, Laurens Van Houtven <_@lvh.cc> wrote:<br><br></div><div></div><blockquote type="cite"><div>Awesome!!!<br><br>At what point did this change? </div></blockquote><div><br></div><div>Not sure. I don't know the history of the github repo nor its uses. I was certainly surprised with Glyph said that pull requests would be accepted.</div><br><blockquote type="cite"><div>ISTR the lack of interest in maintaining the Github account was pretty much a consequence of it seeming pretty pointless: ie it was still easier to just use SVN than to figure out where the parts work together.<br>
<br>Will code review also be happening at a pull request level?<br></div></blockquote><div><br></div><div>Here's what I envision...</div><div><br></div><div>1) a ticket is created on <a href="http://tm.com/trac">tm.com/trac</a> for a feature, bug, etc.</div><div>2) the developer forks the github repo so they can work in their own space, e.g., creating a branch for the new ticket</div><div>3) the ticket is updated with a link to the branch they created on github (e.g., <a href="http://github.com/username/feature-name-1234">github.com/username/feature-name-1234</a>).</div><div>4) when ready for review, the dev rebases against master (which will be syncing with svn every 30 minutes or so), squashing all commits into one and issues a pull request on github</div><div>5) the ticket is updated to review status</div><div>6) other devs take a look at the diff (git clone twisted repo, git pull dev's branch), with review comments going in the trac ticket</div><div>7) dev iterates on feedback, rebasing on master every time</div><div>8) once approved, perform final rebase, and ask that your pull request be merged on github</div><div>9) someone will then ensure that git master is merged into svn trunk</div><div><br></div><div>Note that this hasn't been fully tested yet, so one or more parts of this worklfow may have to change...</div><div><br></div><div>This would allow devs to do 100% of their iteration work in git or hg (hg plays well with github, I hear), basically removing the process itself as a barrier to contributions to Twisted.</div><div><br></div><div>Currently, my own biggest hurdle to resuming contributions to Twisted is the pain of old tech. I've gotten so used to the luxuries of git, hg, and bzr, that svn feels like walking for two days to pick up something at a store, when I can just drive an hour and be there (and not have to walk back home carrying lumber on my back). Everything else I work on (on a daily basis) uses fast, more efficient code repos and more efficient workflows. If forced to use things that slow me down, I'll just pass and do something that quite honestly is a lot more fun.</div><div><br></div><div>Hopefully supporting a workflow like this will bring Twisted contributions back into the "fun"realm for more folks...</div><div><br></div><div>d</div><div><br></div><br><blockquote type="cite"><div><div class="gmail_quote">On Sun, Oct 21, 2012 at 1:24 AM, Duncan McGreggor <span dir="ltr"><<a href="mailto:oubiwann@twistedmatrix.com" target="_blank">oubiwann@twistedmatrix.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey all,<br><br>At the sprint today, Glyph mentioned that the github repo hasn't been updated recently and needs someone to maintain it regularly. He also mentioned that pull requests would be accepted from github, at which point I immediately volunteered to keep the repo up to date :-) (I can't bear using svn anymore...)<br>
<br>I'll be putting things in place (infrastructure, scripts, etc.) to assist me with this, so let me know if you have any concerns, questions, ideas, etc.<br><br>Thanks,<br><br>d<br>
<br>_______________________________________________<br>
Twisted-Python mailing list<br>
<a href="mailto:Twisted-Python@twistedmatrix.com">Twisted-Python@twistedmatrix.com</a><br>
<a href="http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python" target="_blank">http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>cheers<div>lvh</div><br>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>Twisted-Python mailing list</span><br><span><a href="mailto:Twisted-Python@twistedmatrix.com">Twisted-Python@twistedmatrix.com</a></span><br><span><a href="http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python">http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python</a></span><br></div></blockquote></body></html>