<div class="gmail_quote">On Wed, Jan 25, 2012 at 1:06 PM, Matthew Pounsett <span dir="ltr"><<a href="mailto:matt@conundrum.com">matt@conundrum.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I've written some methods for twisted.words.protocols.irc.IRCClient that seem like they (or something like them) should be part of the main distribution. What's the preferred way to pass those along for consideration? Posting here? Open a ticket on the tracker? If the latter, should I send them all as one batch, or separate them into related chunks?<br>
<br>
Thanks!<br>
<br></blockquote></div><br>Probably the best way to submit code is to open a ticket on the tracker, with an attached patch as a unified diff against the current twisted trunk.<br><br>Failing a unified diff, you can attach just a patch, but it will slow down getting your code into Twisted.<br>
<br>Probably the best thing you can do to speed up inclusion of your code into Twisted is to include unit tests with your patch.<br><br>The next best thing is to be active on the ticket. Pay attention to updates, code reviews, etc.<br>
<br>See also: <a href="http://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs">http://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs</a><br><br>Good luck!<br><br>Kevin Horn<br>