<div class="gmail_quote">On Mon, Jul 25, 2011 at 1:22 AM, Glyph Lefkowitz <span dir="ltr"><<a href="mailto:glyph@twistedmatrix.com">glyph@twistedmatrix.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">The main thing that web2 did wrong was introducing a new namespace and thereby confusion, not any particular detail of its implementation.<br></div></blockquote><div><br>Well, my thing would introduce some namespaces (like "entity")-- just not one in the toplevel twisted package.<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im"></div>
The web2 resource model was in most ways a nice upgrade from twisted.web. It even had a halfway decent compatibility layer. You should feel free to copy its implementation liberally (with the exception of the IStream interface, which has been discussed to death elsewhere). However, since web2 was half-baked in some regards, you may need to add test coverage, improve docstrings, or handle some corner cases in order to pass review.<br>
<br></blockquote><div><br>Of course -- I'd end up doing that anyway because I wouldn't feel confident I understand the code otherwise.<br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
But, in terms of implementation details, web2 was in fact "doing it right" for the most part.<br></blockquote><div><br>Glad to know it's not just my mangled mind.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<font color="#888888"><br>
-glyph<br>
</font><div><div></div><div class="h5"><br>
<br>
_______________________________________________<br>
Twisted-Python mailing list<br>
<a href="mailto:Twisted-Python@twistedmatrix.com">Twisted-Python@twistedmatrix.com</a><br>
<a href="http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python" target="_blank">http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>cheers<div>lvh</div><br>