<div class="gmail_quote">On Sat, Jul 2, 2011 at 1:27 AM, Glyph Lefkowitz <span dir="ltr"><<a href="mailto:glyph@twistedmatrix.com">glyph@twistedmatrix.com</a>></span> wrote: <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div style="word-wrap: break-word;"><div><div></div><div style="word-wrap: break-word;">When you do a review, try to be as thorough as possible. Don't <b>ever</b> do a review that says "update @since markers" or "2 blank lines between methods" and nothing else</div>
</div></div></blockquote><div><br>With Github's edit-this-file-on-the-web feature, it will effectively be easier to just fix it than it is to complain about how someone else needs to fix it.<br></div></div><br>cheers<div>
lvh</div><br>