Thanks Drew<div><br></div><div>Yes, you spotted an error in my email, which is not replicated in my code. ie My AdapterQueue in the code inherits from Service. It in turn is a service of a parent which <i>is</i> a MultiService instance.</div>
<div><br></div><div>The tests are Integration tests, not unit tests, and as such run up an instance of our entire messaging gateway. To date we have run it up once at the start of the test run, run all test suites, then torn down (with unclean reactor). The Integration tests have been notoriously brittle, so am hoping that tearing down the gateway after <i>each</i> individual test will help with that. To that end, I have refactored the code to better utilise services, so that teardown (without just stopping the reactor) is possible.</div>
<div><br></div><div>So in the setUp() of each trial.unittest.TestCase, is a call to test_utils.startGateway(). This returns the result of gateway_svc.startService() (starts the parent MultiService of all child services). Each of these setUp methods uses @inlineCallbacks and yields the deferred returned from this top-level startService().</div>
<div><div>@inlineCallbacks</div><div>def setUp(self):</div><div> yield test_utils.startGateway()</div></div><div> {do other set up}</div><div><br></div><div>By the same token, the tearDown() in each test class calls test_utils.tearDown(), which looks like:</div>
<div><br></div><div>class SomeTests(TestCase):</div><div><div> def tearDown(self):</div><div> self.extra_svc.stopService()</div><div> test_utils.tearDown()</div></div><div><br></div><div>Haha! In writing this I've realised what I believe was the problem (and my repeat testing just now has failed to show the intermittent failure). Each test class's tearDown() was <i>not</i> <i>returning</i> the deferred returned from stopService(). Changing the final line above seems to solve the issue:</div>
<div><br></div><div>return test_utils.tearDown()</div><div><br></div><div>Thanks for the sounding board, Drew.</div><div>Cheers</div><div>Brad</div><div><br></div><div><br></div><div><br><div class="gmail_quote">On 17 March 2011 05:06, Drew Smathers <span dir="ltr"><<a href="mailto:drew.smathers@gmail.com">drew.smathers@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">On Tue, Mar 15, 2011 at 9:55 PM, Brad Milne<br>
<<a href="mailto:brad.milne@devx.runthered.com">brad.milne@devx.runthered.com</a>> wrote:<br>
> Hi<br>
> I have a series of MultiService objects, with child Services. Some of these<br>
> services are TCPServers, for example, and others are my own objects<br>
> (extending from Service).<br>
> In the instance that I have a Service which controls a LoopingCall, I am<br>
> getting intermittent 'unclean reactor' errors during tests. I feel I might<br>
> be missing some handling of deferreds, perhaps.<br>
> (using 8.2.0 - looking to migrate to 10.2.0 soon)<br>
> Here is an example of the approach being used:<br>
> class AdapterQueue(service.MultiService):<br>
> def startService(self):<br>
> service.Service.startService(self)<br>
> self._looping_controller = LoopingCall(self._action)<br>
> d = self._looping_controller.start(self.delay, False)<br>
> d.addErrback(self._errorInScheduler)<br>
> def stopService(self):<br>
> service.Service.stopService(self)<br>
> d = self._looping_controller.deferred<br>
> self._looping_controller.stop()<br>
> return d<br>
<br>
<br>
</div>I'm not sure if this is part of the issue or not, but it seems odd<br>
that you may have accidentally inherited from MultiService instead of<br>
Service.<br>
<div><div></div><div class="h5"><br>
<br>
> And an example error (happens about 1/3 of the time):<br>
> DirtyReactorAggregateError: Reactor was unclean.<br>
> DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)<br>
> <DelayedCall 30800112 [0.0189974308014s] called=0 cancelled=0<br>
> LoopingCall<0.033333333333333333>(AdapterQueue._action, *(), **{})()<br>
> traceback at creation:<br>
> File "C:\Python26\lib\threading.py", line 497, in __bootstrap<br>
> self.__bootstrap_inner()<br>
> File "C:\Python26\lib\threading.py", line 525, in __bootstrap_inner<br>
> self.run()<br>
> File "C:\Python26\lib\threading.py", line 477, in run<br>
> self.__target(*self.__args, **self.__kwargs)<br>
> File "D:\dev\eggs\nose-0.11.3-py2.6.egg\nose\twistedtools.py", line<br>
> 57, in <lambda><br>
> installSignalHandlers=False))<br>
> File<br>
> "D:\dev\eggs\twisted-8.2.0-py2.6-win32.egg\twisted\internet\base.py", line<br>
> 1128, in run<br>
> self.mainLoop()<br>
> File<br>
> "D:\dev\eggs\twisted-8.2.0-py2.6-win32.egg\twisted\internet\base.py", line<br>
> 1137, in mainLoop<br>
> self.runUntilCurrent()<br>
> File<br>
> "D:\dev\eggs\twisted-8.2.0-py2.6-win32.egg\twisted\internet\base.py", line<br>
> 757, in runUntilCurrent<br>
> call.func(*call.args, **<a href="http://call.kw" target="_blank">call.kw</a>)<br>
> File<br>
> "D:\dev\eggs\twisted-8.2.0-py2.6-win32.egg\twisted\internet\task.py", line<br>
> 115, in __call__<br>
> d.addCallback(cb)<br>
> File<br>
> "D:\dev\eggs\twisted-8.2.0-py2.6-win32.egg\twisted\internet\defer.py", line<br>
> 195, in addCallback<br>
> callbackKeywords=kw)<br>
> File<br>
> "D:\dev\eggs\twisted-8.2.0-py2.6-win32.egg\twisted\internet\defer.py", line<br>
> 186, in addCallbacks<br>
> self._runCallbacks()<br>
> File<br>
> "D:\dev\eggs\twisted-8.2.0-py2.6-win32.egg\twisted\internet\defer.py", line<br>
> 328, in _runCallbacks<br>
> self.result = callback(self.result, *args, **kw)<br>
> File<br>
> "D:\dev\eggs\twisted-8.2.0-py2.6-win32.egg\twisted\internet\task.py", line<br>
> 103, in cb<br>
> self._reschedule()<br>
> File<br>
> "D:\dev\eggs\twisted-8.2.0-py2.6-win32.egg\twisted\internet\task.py", line<br>
> 139, in _reschedule<br>
> self.call = self.clock.callLater(nextTime - currentTime, self)<br>
>><br>
><br>
<br>
<br>
</div></div>Can you post code for the test? This means generally (as you<br>
suggested) that you haven't waited for all related deferreds to fire<br>
before ending the test. Return the deferred returned by stopService(),<br>
for example, and make final assertions in a callback; but I'm guessing<br>
you already know this.<br>
<br>
<br>
-Drew<br>
<br>
_______________________________________________<br>
Twisted-Python mailing list<br>
<a href="mailto:Twisted-Python@twistedmatrix.com">Twisted-Python@twistedmatrix.com</a><br>
<a href="http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python" target="_blank">http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python</a><br>
</blockquote></div><br><br clear="all"><br>-- <br><span style="font-family:arial, sans-serif;font-size:13px;border-collapse:collapse;color:rgb(136, 136, 136)">Brad Milne | Run The Red | <span style="font-family:arial, sans-serif;font-size:13px;white-space:nowrap"><b><a href="mailto:brad.milne@devx.runthered.com" style="color:rgb(42, 93, 176)" target="_blank">brad.milne@devx.runthered.com</a></b></span></span><br>
</div>