<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 31, 2010, at 1:36 PM, Stefano Debenedetti wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Il 30/10/2010 18:48, Stefano Debenedetti ha scritto:<br><blockquote type="cite"><a href="http://twistedmatrix.com/trac/ticket/4719">http://twistedmatrix.com/trac/ticket/4719</a><br></blockquote><br>I have attached a 2 lines patch that seems to fix the issue.<br><br>The patch also contains a 50 lines unit test ;)<font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></div></blockquote><div><br></div><div>Stefano, this looks like a great contribution: a serious bug fix in a bit of core functionality, with a test. Thanks so much!</div><div><br></div><div>I'll try to do a complete review soon, but my immediate impression is that test_disconnectEvent needs a better docstring. The word 'correctly' in a docstring is always a clue that the writer gave up and stopped trying to describe what 'correct' behavior is :).</div><div><br></div><div>if you could try to rephrase it as "When a transport is (...) and then (...), (...) should be called on (...)".</div><div><br></div><div>(I will have a more concrete suggestion, with fewer "..."s when I have time to go through the ticket history and review the patch in detail.)</div><br><blockquote type="cite"><div>I hope this makes it on time for the 10.2.0 release.<br><br>BTW there's a small error here:<br><br><a href="http://twistedmatrix.com/trac/wiki/BasicGuideToContributingCode">http://twistedmatrix.com/trac/wiki/BasicGuideToContributingCode</a><br><br>$ svn diff -u<br>Subcommand 'diff' doesn't accept option '-u [--show-updates]'<br>Type 'svn help diff' for usage.<br><br>So the correct command for generating a patch should be documented as:<br><br>svn diff > my-twisted-patch.patch<br><br>thanks ciao<br>ste<br><br>_______________________________________________<br>Twisted-Python mailing list<br>Twisted-Python@twistedmatrix.com<br>http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python<br></div></blockquote></div><br></body></html>