<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 16, 2010, at 5:34 PM, Jason J. W. Williams wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Menlo; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><span class="Apple-style-span" style="font-family: monospace; ">Given I've only used Twisted in the past and not contributed to it, I<br>was curious if someone could take a look at my changes to<br>twisted.python.logfile.LogFile's rotate() method and see if there's<br>any reason the changes would be a bad idea.<br></span></span></blockquote></div><div><br></div><div>The right way to ask this question is to open a ticket on <a href="http://twistedmatrix.com">twistedmatrix.com</a> and put it into review (attach the 'review' keyword). More information is available here: <<a href="http://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs">http://twistedmatrix.com/trac/wiki/ContributingToTwistedLabs</a>>. Otherwise, unless someone has a chance to look at it right away (which is always unlikely) it will languish in the mailing list archive forever.</div><div><br></div><div>Be sure to check back on the ticket when you receive feedback, as approximately 0% of suggested patches are actually accepted as-is without some cleanup :).</div><div><br></div><div>Thanks!</div><div><br></div></body></html>