<div class="gmail_quote">On Thu, Oct 1, 2009 at 10:21 PM, Benjamin Rutt <span dir="ltr"><<a href="mailto:rutt.4@osu.edu">rutt.4@osu.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<span style="border-collapse: collapse;"><div dir="ltr" align="left"><font face="Arial"><font color="#0000ff"><font size="2"><span>(A/B) it looks like the SSHChannel implementation of getPeer() is faulty. If I change my two-line implementation of getPeer() inside SSHSessionProcessProtocol to simply 'return self.session.getPeer()', I get:</span></font></font></font></div>
<div dir="ltr" align="left"><font face="Arial"><font color="#0000ff"><font size="2"><span><br> File "/home/ruttbe/dev/python/twisted-8.2.0-inst/lib/python/twisted/conch/ssh/session.py", line 216, in getPeer<br>
return self.session.getPeer()<br> File "/home/ruttbe/dev/python/twisted-8.2.0-inst/lib/python/twisted/conch/ssh/channel.py", line 261, in getPeer<br> return('SSH', )+self.conn.transport.getPeer()<br>
AttributeError: SSHServerTransport instance has no attribute 'getPeer'</span></font></font></font><font><font><span></span></font></font></div><div></div></span></blockquote><div><br>OK, I give up :). Looks like that is pretty clearly a bug, though.<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><span style="border-collapse: collapse;">
<div><font size="2" color="#0000ff" face="Arial"><span>(C) regarding adding a test, which file do you think would be suitable here? something in the twisted/test dir?</span></font></div></span></blockquote><div><br>I am not sure which exact file, but something of the form twisted/conch/test/test_<something>.py<br>
<br>Paul Swartz (z3p) should really weigh in on this. You can find him on IRC most days, although hopefully he's reading the mailing list :).<br><br></div></div><br>