<div class="gmail_quote">On Mon, Aug 3, 2009 at 8:56 PM, Laurens Van Houtven <span dir="ltr"><<a href="mailto:lvh@laurensvh.be">lvh@laurensvh.be</a>></span> wrote:<br><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I could produce an actual patch, but perhaps it would be more useful<br>
to do this with the Launchpad-published bzr branch? Obviously that<br>
means I can't attach a real patch to a trac ticket. If people want me<br>
to, I will.</blockquote><div><br>The ticket is currently pending review, so when someone has some time for Twisted reviews, you should get some feedback on it. You might want to attach a comment that makes it very clear for a reviewer where the code actually is, since the ticket seems to have begun its life in the 'review' state; it's a bit unorthodox for someone to keep working on a ticket once it's been submitted for review. The normal workflow is to have the comment that attaches the 'review' keyword be the submission for review, and the comment that removes it be the review commentary. (Or something close to that, trac's UI is so hard to drive.)<br>
<br>We've got a bit of a review backlog right now so there may be some latency :-\. Perhaps you should volunteer to review some tickets yourself? :)<br><br>The way to get from your launchpad branch to the relevant SVN-like diff is this:<br>
<br>bzr get lp:~lvh/twisted/positioning positioning-3926<br>cd positioning-3926<br>bzr diff -r ancestor:lp:twisted<br><br>Attaching this patch to the ticket may make a reviewer's life easier; not everyone is equally facile with bzr.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Some of the obvious problems that I've seen myself or that come up on<br>
the mailing list are tagged with "REVIEW", so if you only have 10<br>
minutes to look at it, grep nmea.py for it :-)<br>
<br>
Obvious TODO is howto documentation, but I'm not starting on that<br>
until the API has been reviewed thoroughly for obvious reasons.<br>
</blockquote><div><br>This can be a separate ticket.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Here it is: <a href="http://bit.ly/3wWL2c" target="_blank">http://bit.ly/3wWL2c</a><br>
<br>
Or you could just: bzr branch lp:~lvh/twisted/positioning<br><a href="http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python" target="_blank">http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python</a></blockquote>
</div>