<html><body>On 01:32 am, timothyfitz@gmail.com wrote:<br />>Recently there have been some changes to ThreadedSelectReactor,<br />>specifically that it is no longer being considered as a stand alone<br />>reactor choice (for example, you will no longer be able to twistd<br />>--reactor=threadedselect). This action is desirable since there's no<br />>reason for it. As I understand TSR it's broken for that usage anyway;<br />>however, I have been warned that TSR is completely broken and<br />>shouldn't be used at all. What exactly and specifically are the<br />>current problems or at least symptoms of TSR and is it truly broken?<br /><br />Excellent question.  The initial problem is that it has approximately<br />zero test coverage.  You cannot run Twisted's test suite using tsr, so<br />who knows what it does?  Any change made by any developer to Twisted<br />might break it completely; as a tsr user, you might be the first to notice<br />this circumstance.  Not an ideal situation in the least.<br /><br />If tsr is important, I would suggest finding a way to run Twisted's test<br />suite using it.  One way to do this is to implement the actual reactor<br />API using a subclass (or some such).  Trial might then run the test suite<br />using that reactor subclass.  Hopefully there will be support for reactor<br />plugins somewhat soon, but until then you'll need to patch the reactors<br />dictionary at the top of twisted/application/app.py.<br /><br />Jean-Paul<br /></body></html>