* The changes modify public APIs which are undocumented (ie, a
function which has no docstring is modified, or a class which has no
docstring has methods added to it) without adding documentation.<br><br>Since when are tests public APIs?<br><br>C<br><br><div><span class="gmail_quote">On 9/22/06, <b class="gmail_sendername"><a href="mailto:glyph@divmod.com">
glyph@divmod.com</a></b> <<a href="mailto:glyph@divmod.com">glyph@divmod.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Fri, 22 Sep 2006 08:58:36 -0400, Jean-Paul Calderone <<a href="mailto:exarkun@divmod.com">exarkun@divmod.com</a>> wrote:<br><br>>Docstring?<br><br>I'd like to direct all reviewers' attention at this point to the excellent wiki page that Chris and JP wrote a little while ago:
<br><br> <a href="http://twistedmatrix.com/trac/wiki/ReviewProcess">http://twistedmatrix.com/trac/wiki/ReviewProcess</a><br><br>Especially to this section:<br><br>"""<br><br> A reviewer must reject a set of changes in any of the following circumstances:
<br><br> * The test suite fails on any of the supported* platforms as a result of the changes.<br> * The changes alter the behavior of code in a way which is not tested.<br> * The changes add new behavior without adding test coverage for that behavior.
<br> * The changes modify public APIs which are undocumented (ie, a function which has no docstring is modified, or a class which has no docstring has methods added to it) without adding documentation.<br> * The changes modify the behavior of a documented API without updating the documentation.
<br> * The changes violate the coding standard.<br><br>"""<br><br>_______________________________________________<br>Twisted-Python mailing list<br><a href="mailto:Twisted-Python@twistedmatrix.com">Twisted-Python@twistedmatrix.com
</a><br><a href="http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python">http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python</a><br></blockquote></div><br>