[Twisted-Python] Need help reviewing improvement to inlineCallbacks

Craig Rodrigues rodrigc at crodrigues.org
Wed Sep 20 10:42:47 MDT 2017


Pierre Tardy, the main developer of Buildbot,
submitted this patch to add full stack traces
to inlineCallbacks:

https://github.com/twisted/twisted/pull/814

I think the patch looks good, but can someone with more
knowledge of inlineCallbacks review it?

Right now, if you have a stack of inlineCallbacks,
andan exception is thrown, some of the stacktrace is
lost.  By adding full stack traces to inlineCallbacks,
this greatly improves the debuggability of software like
Buildbot, which makes heavy use of inlineCallbacks.

--
Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20170920/06358175/attachment.html>


More information about the Twisted-Python mailing list