[Twisted-Python] admin/pr_as_branch

[Jean-Paul Calderone]

On Sun, Jan 22, 2017 at 8:19 PM, Glyph Lefkowitz <glyph at twistedmatrix.com>
wrote:

>
> On Jan 22, 2017, at 5:15 PM, Jean-Paul Calderone <
> exarkun at twistedmatrix.com> wrote:
>
> Hello,
>
> I didn't find any hints about the workflow surrounding the
> admin/pr_as_branch tool so I invented one and wrote it up on the wiki:
>
> https://twistedmatrix.com/trac/wiki/ReviewProcess?action=diff&version=76
>
> Jean-Paul
>
>
> Thanks for writing this up.  The workflow is evolving organically.
>
> However, the "close the PR" step confuses me.  If you do this, the
> original contributor won't be able to respond to feedback.  What is the
> desired effect of this second PR?
>


The idea I heard is that it provides a place to hang build failure-related
review comments.  I also had some vague notion that it would be the place
you'd look to see the complete CI results.

So.  Where should further reviews go and where do you find CI results, if
you don't create a new PR?

Jean-Paul



>
> -glyph
>
>
> _______________________________________________
> Twisted-Python mailing list
> Twisted-Python at twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20170122/368aeb3f/attachment-0002.html>