[Twisted-Python] overview: new review queue venue

Daniel Sank sank.daniel at gmail.com
Sun May 22 00:24:56 MDT 2016


All,

> Please do not use squash commits.  See
http://mjg59.dreamwidth.org/42759.html.

Squashing commits is essential to making useful commit histories. Are you
just saying not to use Github's built-in feature which squashes everything
into a _single_ commit? If so, note that you can turn that GUI feature off
so nobody is tempted to use it. That does leave the question of whether you
want people to use merge commits or to rebase their branch on the latest
master before merging so that you always get a fast-forward.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20160521/17f40ed3/attachment-0002.html>


More information about the Twisted-Python mailing list