[Twisted-Python] setup.py broken in trunk
Glyph Lefkowitz
glyph at twistedmatrix.com
Sun Aug 21 11:10:11 MDT 2016
> On Aug 21, 2016, at 4:19 AM, Adi Roiban <adi at roiban.ro> wrote:
>
> On 21 August 2016 at 11:13, Glyph Lefkowitz <glyph at twistedmatrix.com> wrote:
>> 41482c4fe5442bcc7b046ab53bf15409f2031abd makes a change such that 'pip install -e .' (and indeed, 'pip install .') no longer installs 'twist'.
>>
>> I think we should revert this.
>>
>> Clearly we have a problem with our test suite, if we're not catching the binaries disappearing on us :-).
>
> I have reverted and re-submitted the ticket for review. Sorry for the trouble!
Thanks for fixing!
> I have not yet added integration tests for the console scripts.
>
> I think that before writing such tests we need to make sure that
> development environments and CI environments all have `pip install -e
> .` or something similar called.
>
> For more details see https://twistedmatrix.com/trac/ticket/8622#comment:8
> Craig is pushing for removing bin/trial and after bin/trial is removed
> I think that all environments will need to have `pip install .` called
> so that we don't run the OS trial version.
>
> There is also ticket https://twistedmatrix.com/trac/ticket/8544 which
> tries to create tox environments for all Buildbot builders so that we
> can run everything with Tox on buildbot CI system.
Once we have `tox` everywhere, we don't need a separate step to run `pip`. This seems like the right way to address it.
-g
More information about the Twisted-Python
mailing list