[Twisted-Python] feedback on next version of Fireshark using twisted framework....

[Stephan]

Hi I have an open source project that is pretty well-known in the security
community. http://www.fireshark.org
it's a service wrapper that runs a headless version of firefox to visit
malicious sites to store telemetry data.

The old service used PERL for threading (very painful), so a while ago I
changed everything to python using
the twisted framework. the service's job is to launch a choose a firefox
profile, launch the process and
handle closes and crashes approprietly.

the launch of version 2.5 is next week but I sure could use some feedback
on the service code before releasing it.
Keep in mind I haven't finishing commenting for public release.

here are the files for the new service:

1)
fireshark.py http://pastebin.mozilla.org/1614427

this is the main service. opens up a port to listen on, and uses the
following two classes to manage profiles and launch
a firefox process.

2)
firesharkprofilemanager.py http://pastebin.mozilla.org/1614428

this is the firefox profile manager, it manages what firefox profiles are
available.

3)
firefoxprocess.py http://pastebin.mozilla.org/1614431

this is the firefox process class, to check if  the launched process has
been killed as well, as check if the logging from
the internal plugin (another part of the fireshark project) has completed
logging.

Thanks in advance! Twisted has been a great Framework!
Stephan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20120503/10063e96/attachment.html>